This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
[MAJOR CHANGES] Jasmine 2.0 support and added Junit XML formatter for Jasmine < 2.0 and some refactoring. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated reporters to add more info and also the console output to ressemble more with Rspec
|
I would really like some feedback on this. Can somebody please review this? And then i can start on adding tests and documentation and checking the style guide ..but i think those can be done in other pull requests. |
bogdanRada
changed the title
|
can someone please review this pull request? it's been 2 months since i opened this pull request and i still have no feedback. |
|
Any update on this?is this repository still maintained ? |
|
Any updates on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for this great project. Although this doesn't seem to be maintained in over 4 years, i updated the code and added a new reporter for Jasmine 2.0 and did a lot of refactoring,
Also did some changes to the console output to provide more information, including stack traces.
And also added Junit XML formatter for Jasmine < 2.0, because most of the gems out there work only with Jasmine 2.0 and they have dependencies either to nodejs, or poltergeist or phantomjs, and because legacy versions that are lower than 1.3.1 don't seem to be supported by anyone.
This though is a ruby implementation and this formatter will work only with legacy versions.
Let me know what you think. Thank you very much.
Also please let me know if you want me to refactor some code, this might not be ideal.
I tested it with both versions and seems to work ok.