Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider-specific webhooks in Garden cluster #15

Closed
rfranzke opened this issue Feb 4, 2020 · 2 comments · Fixed by #49
Closed

Provider-specific webhooks in Garden cluster #15

rfranzke opened this issue Feb 4, 2020 · 2 comments · Fixed by #49
Assignees
Labels
kind/enhancement Enhancement, improvement, extension

Comments

@rfranzke
Copy link
Member

rfranzke commented Feb 4, 2020

From gardener-attic/gardener-extensions#407

With the new core.gardener.cloud/v1alpha1.Shoot API Gardener does no longer understand the provider-specifics, e.g., the infrastructure config, control plane config, worker config, etc.
This allows end-users to harm themselves and create invalid Shoot resources the Garden cluster. Errors will only become present during reconciliation part creation of the resource.

Also, it's not possible to default any of the provider specific sections. Hence, we could also think about mutating webhooks in the future.

As we are using the controller-runtime maintained by the Kubernetes SIGs it should be relatively easy to implement these webhooks as the library abstracts already most of the things.

We should have a separate, dedicated binary incorporating the webhooks for each provider, and a separate Helm chart for the deployment in the Garden cluster.

Similarly, the networking and OS extensions could have such webhooks as well to check on the providerConfig for the networking and operating system config.

Part of gardener/gardener#308

@ialidzhikov
Copy link
Member

Comment gardener/gardener-extension-provider-aws#30 (comment).

$index is used also in the alicloud infra chart. We can keep in mind to add the same validation check also there once we introduce the validator for provider-alicloud.

@jia-jerry jia-jerry self-assigned this Feb 17, 2020
@rfranzke
Copy link
Member Author

rfranzke commented Mar 4, 2020

@jia-jerry @minchaow @EmoinLanyu There is a "reference implementation for Azure that you can look at: gardener/gardener-extension-provider-azure#45.
And https://github.com/gardener/gardener-extension-provider-aws/tree/master/cmd/gardener-extension-validator-aws, of course, which is more close to Alicloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants