Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove garden-cli and garden-sync from build process #468

Closed
eysi09 opened this issue Jan 21, 2019 · 2 comments
Closed

Remove garden-cli and garden-sync from build process #468

eysi09 opened this issue Jan 21, 2019 · 2 comments
Assignees
@eysi09
Labels
refactor Things that should be cleaned up or refactored, but don't affect users

Comments

@eysi09
Copy link
Collaborator

eysi09 commented Jan 21, 2019

Currently we have several unnecessary build steps, both local and in CI:

  • build garden-cli go binary
  • build and release garden-sync docker image
  • build and release garden-service docker image

These are remnants of our experiment with running the Garden service in a container with a Go CLI in front of it.

We should remove these steps as they cause unnecessary complexity. Furthermore we should add a readme to the garden-cli and garden-sync repos explaining their purpose.
@eysi09 eysi09 self-assigned this Jan 22, 2019
@eysi09
Copy link
Collaborator Author

eysi09 commented Jan 28, 2019

We should also use to chance to either close or merge #364.

@eysi09 eysi09 added the refactor Things that should be cleaned up or refactored, but don't affect users label Jan 28, 2019
@eysi09 eysi09 mentioned this issue Feb 5, 2019
Merged
@eysi09
Copy link
Collaborator Author

eysi09 commented Feb 5, 2019

Closed in #515.

@eysi09 eysi09 closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eysi09 eysi09

Labels
refactor Things that should be cleaned up or refactored, but don't affect users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eysi09