Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Sywac CLI framework #393

Closed
edvald opened this issue Nov 28, 2018 · 3 comments
Closed

Get rid of Sywac CLI framework #393

edvald opened this issue Nov 28, 2018 · 3 comments
Labels
good first issue refactor Things that should be cleaned up or refactored, but don't affect users

Comments

@edvald
Copy link
Collaborator

edvald commented Nov 28, 2018

Sywac isn't maintained much and is poorly documented, and I feel like mapping our commands to it is uglier than just switching to a simpler arg parser (e.g. https://github.com/sindresorhus/meow).

nb. We also looked a bit into oclif.io as well, but it doesn't appear to fit easily with our needs, even though it seems like a nice framework.

Not a high priority task, but maybe a nice first issue for someone, would clean up our code a bit.

@edvald edvald added the refactor Things that should be cleaned up or refactored, but don't affect users label Nov 28, 2018
@davidkjackson54
Copy link

It appears that sywac may have died a death. Doesn't seem to have been touched in 6 months.
Seems to have gone the same way as yargonaut by the same author. Started but then seemingly dropped.
Would like to see a public statement by the author as to the status. I wouldn't want to waste a lot of time converting without a clear path.

@edvald
Copy link
Collaborator Author

edvald commented Jan 3, 2019

That seems to be the case. Thankfully we're not tightly coupled to it. Most of our related code is glue between Sywac and our underlying Command abstraction (which we created to avoid this type of coupling, and to allow other methods of using the commands such as HTTP API calls).

@eysi09
Copy link
Collaborator

eysi09 commented Sep 27, 2019

This doesn't feel relevant. Lets revisit when we need to.

@eysi09 eysi09 closed this as completed Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue refactor Things that should be cleaned up or refactored, but don't affect users
Projects
None yet
Development

No branches or pull requests

4 participants