Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Add tolerations to many garden-run pods #3031

Closed
to266 opened this issue Jul 1, 2022 · 2 comments
Closed

[FEATURE]: Add tolerations to many garden-run pods #3031

to266 opened this issue Jul 1, 2022 · 2 comments
Labels
feature request stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity.

Comments

@to266
Copy link
Contributor

to266 commented Jul 1, 2022

Feature Request

Background / Motivation

Would love to add kubernetes tolerations to various garden-run resources - such as tests, tasks, cluster-buildkit pod (and anything else I may have missed for that matter)

What should the user be able to do?

Specify tolerations for container.tests[].tolerations, container.tasks[].tolerations as well as for the providers[].clusterBuildkit.tolerations.

Why do they want to do this? What problem does it solve?

That way I would not need to use expensive on-demand nodes, and could rely on the much cheaper spot instances. (In the particular azure case, each spot instance has a taint by default, and it's impossible to get rid of it).

Suggested Implementation(s)

Just allow passing the setting for each of the objects. With the project variables, it's simple to manage it centrally via that mechanism.

How important is this feature for you/your team?

🌵 Not having this feature makes using Garden needlessly expensive

@thsig
Copy link
Collaborator

thsig commented Jul 7, 2022

Hi @to266!

Tests and tasks for kubernetes and helm modules will apply any toleration config from the pod spec of the service resource to the one-off pods used when running the test/task. See https://docs.garden.io/reference/module-types/kubernetes#tests-.resource for a complete list of fields from the pod spec that are included.

The container module type doesn't expose all pod spec fields (we're intentionally trying to avoid introducing too many Kubernetes-specific fields to the container module type for the time being, since the idea is for that module type not to be overly Kubernetes-specific).

@stale
Copy link

stale bot commented Oct 16, 2022

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Oct 16, 2022
@stale stale bot closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity.
Projects
None yet
Development

No branches or pull requests

2 participants