fix(config): whitespace was incorrrectly stripped around format strings

garden-io · Jul 24, 2019 · ee32557 · ee32557
1 parent 91047e5
commit ee32557
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/garden-service/src/template-string-parser.pegjs b/garden-service/src/template-string-parser.pegjs
@@ -48,10 +48,10 @@ InvalidFormatString
   }
 
 FormatStart
-  = ws "${" ws
+  = "${" ws
 
 FormatEnd
-  = ws "}" ws
+  = ws "}"
 
 Identifier
   = [a-zA-Z][a-zA-Z0-9_\-]* { return text() }

diff --git a/garden-service/test/unit/src/template-string.ts b/garden-service/test/unit/src/template-string.ts
@@ -38,6 +38,21 @@ describe("resolveTemplateString", async () => {
     expect(res).to.equal("value-suffix")
   })
 
+  it("should interpolate a format string with a prefix with whitespace", async () => {
+    const res = await resolveTemplateString("prefix ${some}", new TestContext({ some: "value" }))
+    expect(res).to.equal("prefix value")
+  })
+
+  it("should interpolate a format string with a suffix with whitespace", async () => {
+    const res = await resolveTemplateString("${some} suffix", new TestContext({ some: "value" }))
+    expect(res).to.equal("value suffix")
+  })
+
+  it("should correctly interpolate a format string with surrounding whitespace", async () => {
+    const res = await resolveTemplateString("prefix ${some} suffix", new TestContext({ some: "value" }))
+    expect(res).to.equal("prefix value suffix")
+  })
+
   it("should handle a nested key", async () => {
     const res = await resolveTemplateString("${some.nested}", new TestContext({ some: { nested: "value" } }))
     expect(res).to.equal("value")