fix(cli): fix janky spinner when initializing providers

This avoids triggering the log writers if their level is lower than
the log entry. This was particularly apparent when initializing
providers because that process triggers a lot of verbose+ entries.

garden-service/src/cli/cli.ts

@@ -152,7 +152,7 @@ export const GLOBAL_OPTIONS = {
 export type GlobalOptions = typeof GLOBAL_OPTIONS
 
 function initLogger({ level, loggerType, emoji }: { level: LogLevel; loggerType: LoggerType; emoji: boolean }) {
-  const writer = getWriterInstance(loggerType)
+  const writer = getWriterInstance(loggerType, level)
   const writers = writer ? [writer] : undefined
   return Logger.initialize({ level, writers, useEmoji: emoji })
 }

garden-service/src/logger/logger.ts

@@ -20,35 +20,14 @@ import { parseLogLevel } from "../cli/helpers"
 export type LoggerType = "quiet" | "basic" | "fancy" | "json"
 export const LOGGER_TYPES = new Set<LoggerType>(["quiet", "basic", "fancy", "json"])
 
-export function getLoggerConfig(loggerType: LoggerType): LoggerConfig {
-  const configs: { [key in LoggerType]: LoggerConfig } = {
-    quiet: {
-      level: LogLevel.info,
-    },
-    basic: {
-      level: LogLevel.info,
-      writers: [new BasicTerminalWriter()],
-    },
-    fancy: {
-      level: LogLevel.info,
-      writers: [new FancyTerminalWriter()],
-    },
-    json: {
-      level: LogLevel.info,
-      writers: [new JsonTerminalWriter()],
-    },
-  }
-  return configs[loggerType]
-}
-
-export function getWriterInstance(loggerType: LoggerType) {
+export function getWriterInstance(loggerType: LoggerType, level: LogLevel) {
   switch (loggerType) {
     case "basic":
-      return new BasicTerminalWriter()
+      return new BasicTerminalWriter(level)
     case "fancy":
-      return new FancyTerminalWriter()
+      return new FancyTerminalWriter(level)
     case "json":
-      return new JsonTerminalWriter()
+      return new JsonTerminalWriter(level)
     case "quiet":
       return undefined
   }
@@ -102,7 +81,7 @@ export class Logger extends LogNode {
         })
       }
 
-      const writer = getWriterInstance(loggerType)
+      const writer = getWriterInstance(loggerType, config.level)
       instance = new Logger({
         writers: writer ? [writer] : undefined,
         level: config.level,
@@ -132,7 +111,11 @@ export class Logger extends LogNode {
   }
 
   onGraphChange(entry: LogEntry) {
-    this.writers.forEach((writer) => writer.onGraphChange(entry, this))
+    for (const writer of this.writers) {
+      if (entry.level <= writer.level) {
+        writer.onGraphChange(entry, this)
+      }
+    }
   }
 
   getLogEntries(): LogEntry[] {

garden-service/src/logger/writers/base.ts

@@ -8,8 +8,13 @@
 
 import { LogEntry } from "../log-entry"
 import { Logger } from "../logger"
+import { LogLevel } from "../log-node"
 
 export abstract class Writer {
+  abstract type: string
+
+  constructor(public level: LogLevel = LogLevel.info) {}
+
   abstract render(...args): string | string[] | null
   abstract onGraphChange(entry: LogEntry, logger: Logger): void
   abstract stop(): void

garden-service/src/logger/writers/basic-terminal-writer.ts

@@ -12,6 +12,8 @@ import { Logger } from "../logger"
 import { Writer } from "./base"
 
 export class BasicTerminalWriter extends Writer {
+  type = "basic"
+
   render(entry: LogEntry, logger: Logger): string | null {
     return basicRender(entry, logger)
   }

garden-service/src/logger/writers/fancy-terminal-writer.ts

@@ -42,17 +42,17 @@ export interface CustomStream extends NodeJS.WriteStream {
 }
 
 export class FancyTerminalWriter extends Writer {
+  type = "fancy"
+
   private spinners: { [key: string]: Function }
   private intervalID: NodeJS.Timer | null
   private stream: CustomStream
   private prevOutput: string[]
   private lastInterceptAt: number | null
   private updatePending: boolean
 
-  public level: LogLevel
-
-  constructor() {
-    super()
+  constructor(level: LogLevel = LogLevel.info) {
+    super(level)
     this.intervalID = null
     this.spinners = {} // Each entry has it's own spinner
     this.prevOutput = []

garden-service/src/logger/writers/file-writer.ts

@@ -48,13 +48,14 @@ export function render(level: LogLevel, entry: LogEntry): string | null {
 }
 
 export class FileWriter extends Writer {
+  type = "file"
+
   private fileLogger: winston.Logger | null
   private logFilePath: string
   private fileTransportOptions: FileTransportOptions
-  public level: LogLevel
 
   constructor(logFilePath: string, config: FileWriterConfig) {
-    super()
+    super(config.level)
 
     const { fileTransportOptions = DEFAULT_FILE_TRANSPORT_OPTIONS, level } = config
     this.level = level

garden-service/src/logger/writers/json-terminal-writer.ts

@@ -6,7 +6,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-import { LogLevel } from "../log-node"
 import { LogEntry, LogEntryMetadata } from "../log-entry"
 import { Logger } from "../logger"
 import { Writer } from "./base"
@@ -21,7 +20,7 @@ export interface JsonLogEntry {
 }
 
 export class JsonTerminalWriter extends Writer {
-  public level: LogLevel
+  type = "json"
 
   render(entry: LogEntry, logger: Logger): string | null {
     const level = this.level || logger.level