fix: update messaging when checking version

garden-service/src/cli/helpers.ts

@@ -23,7 +23,7 @@ import qs = require("qs")
 import { platform, release } from "os"
 import { LogEntry } from "../logger/log-entry"
 import { VERSION_CHECK_URL } from "../constants"
-import { printHeader } from "../logger/util"
+import { printWarningMessage } from "../logger/util"
 import { GlobalConfigStore, globalConfigKeys } from "../config-store"
 import moment = require("moment")
 
@@ -228,13 +228,12 @@ export async function checkForUpdates(config: GlobalConfigStore, logger: LogEntr
     const showMessage = (configObj.lastVersionCheck
       && moment().subtract(1, "days").isAfter(moment(configObj.lastVersionCheck.lastRun)))
 
+    // we check again for lastVersionCheck because in the first run it doesn't exist
     if (showMessage || !configObj.lastVersionCheck) {
       if (res.data.status === "OUTDATED") {
-        printHeader(logger, res.data.message, "warning")
-      } else {
-        printHeader(logger, res.data.message, "thumbsup")
+        printWarningMessage(logger, res.data.message)
+        await config.set([globalConfigKeys.lastVersionCheck], { lastRun: new Date() })
       }
-      await config.set([globalConfigKeys.lastVersionCheck], { lastRun: new Date() })
     }
   } catch (err) {
     logger.verbose("Something went wrong while checking for the latest Garden version.")

garden-service/src/logger/util.ts

@@ -129,3 +129,11 @@ export function printHeader(log: LogEntry, command: string, emoji?: EmojiName):
 export function printFooter(log: LogEntry) {
   return printWithEmoji(log, "Done!", "heavy_check_mark")
 }
+
+export function printWarningMessage(log: LogEntry, text: string) {
+  const msg = combine([
+    [log.root.useEmoji ? printEmoji("warning") : ""],
+    [chalk.bold.yellow(text)],
+  ])
+  return log.info(msg)
+}