From 93ee43c2ac31ebbfe76b732f2de00df4d6c787c0 Mon Sep 17 00:00:00 2001 From: Jon Edvald Date: Mon, 11 Nov 2019 17:20:20 +0100 Subject: [PATCH] improvement(k8s): skip superfluous service endpoint check This check was introduced when resolving an issue a while ago, but it doesn't appear that this check is really necessary. --- garden-service/src/plugins/kubernetes/status/status.ts | 7 ------- 1 file changed, 7 deletions(-) diff --git a/garden-service/src/plugins/kubernetes/status/status.ts b/garden-service/src/plugins/kubernetes/status/status.ts index cc3fc2e99f..d4b1d9648e 100644 --- a/garden-service/src/plugins/kubernetes/status/status.ts +++ b/garden-service/src/plugins/kubernetes/status/status.ts @@ -31,7 +31,6 @@ import dedent = require("dedent") import { getPods } from "../util" import { checkWorkloadStatus } from "./workload" import { checkWorkloadPodStatus } from "./pod" -import { waitForServiceEndpoints } from "./service" import { gardenAnnotationKey } from "../../../util/string" import stringify from "json-stable-stringify" @@ -213,12 +212,6 @@ export async function waitForResources({ ctx, provider, serviceName, resources, } if (combineStates(statuses.map((s) => s.state)) === "ready") { - // If applicable, wait until Services properly point to each Pod in the resource list. - // This step is put in to give the cluster a moment to update its network routing. - // For example, when a Deployment passes its health check, Kubernetes doesn't instantly route Service traffic - // to it. We need to account for this so that dependant tasks, tests and services can reliably run after this - // routine resolves. - await waitForServiceEndpoints(api, statusLine, namespace, resources) break }