From 92c646a7a209a16a2235ee563ee510beb992535b Mon Sep 17 00:00:00 2001 From: Wilf Wilson Date: Fri, 15 May 2020 18:29:19 +0100 Subject: [PATCH 1/6] pperm: add trivial test to increase code coverage --- tst/testinstall/pperm.tst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tst/testinstall/pperm.tst b/tst/testinstall/pperm.tst index 148d74d26e..2add5f08c9 100644 --- a/tst/testinstall/pperm.tst +++ b/tst/testinstall/pperm.tst @@ -4117,6 +4117,11 @@ true gap> OnTuples([1], PartialPerm([])) = []; true +# +gap> SetUserPreference("PartialPermDisplayLimit", 1); +gap> PartialPerm([1], [2]); + + # gap> SetUserPreference("PartialPermDisplayLimit", display);; gap> SetUserPreference("NotationForPartialPerm", notationpp);; From 84c8ea206bec48db31a4fc3fee40ad690fb471b4 Mon Sep 17 00:00:00 2001 From: Wilf Wilson Date: Mon, 4 May 2020 12:48:26 +0100 Subject: [PATCH 2/6] vspc{row,mat}: Use ListWithIdenticalEntries in Coefficients --- lib/vspcmat.gi | 7 ++----- lib/vspcrow.gi | 3 +-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/vspcmat.gi b/lib/vspcmat.gi index 11c5528458..4501237e24 100644 --- a/lib/vspcmat.gi +++ b/lib/vspcmat.gi @@ -190,11 +190,8 @@ InstallMethod( Coefficients, fi; # Preset the coefficients list with zeroes. - zero := Zero( v[1][1] ); - coeff := []; - for i in [ 1 .. Length( vectors ) ] do - coeff[i]:= zero; - od; + zero:= Zero( v[1][1] ); + coeff:= ListWithIdenticalEntries( Length( vectors ), zero ); # Compute the coefficients of the basis vectors. m:= Length( v ); diff --git a/lib/vspcrow.gi b/lib/vspcrow.gi index 8d41a4a746..c60f074358 100644 --- a/lib/vspcrow.gi +++ b/lib/vspcrow.gi @@ -315,8 +315,7 @@ InstallMethod( Coefficients, fi; # Preset the coefficients list with zeroes. - zero:= Zero( v[1] ); - coeff:= List( vectors, x -> zero ); + coeff:= ListWithIdenticalEntries( Length( vectors ), Zero( v[1] ) ); # Compute the coefficients of the base vectors. v:= ShallowCopy( v ); From f66abf74c9fecef7cfd0a886064b24b82310fef9 Mon Sep 17 00:00:00 2001 From: Wilf Wilson Date: Wed, 20 Jan 2021 09:51:58 +0000 Subject: [PATCH 3/6] IsNaturalAn/Sn: simplify trivial case; cheaper test first --- lib/gpprmsya.gi | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/lib/gpprmsya.gi b/lib/gpprmsya.gi index 625c8cd741..08ed213f24 100644 --- a/lib/gpprmsya.gi +++ b/lib/gpprmsya.gi @@ -673,14 +673,8 @@ InstallMethod(IsNaturalAlternatingGroup,"knows size",true,[IsPermGroup end ); InstallMethod(IsNaturalAlternatingGroup,"comprehensive",true,[IsPermGroup],0, -function( grp ) - if 0 = NrMovedPoints(grp) then - return IsTrivial(grp); - else - return PermgpContainsAn(grp)=true and - ForAll(GeneratorsOfGroup(grp),i->SignPerm(i)=1); - fi; -end ); +G -> IsTrivial(G) or + ForAll(GeneratorsOfGroup(G),i->SignPerm(i)=1) and PermgpContainsAn(G)=true); ############################################################################# ## @@ -705,14 +699,8 @@ InstallMethod(IsNaturalSymmetricGroup,"knows size",true,[IsPermGroup end ); InstallMethod(IsNaturalSymmetricGroup,"comprehensive",true,[IsPermGroup],0, -function( grp ) - if 0 = NrMovedPoints(grp) then - return IsTrivial(grp); - else - return PermgpContainsAn(grp)=true and - ForAny(GeneratorsOfGroup(grp),i->SignPerm(i)=-1); - fi; -end ); +G -> IsTrivial(G) or + ForAny(GeneratorsOfGroup(G),i->SignPerm(i)=-1) and PermgpContainsAn(G)=true); ############################################################################# ## From 601a55bee836f1de769c2dc53dbfb9052e40aa92 Mon Sep 17 00:00:00 2001 From: Wilf Wilson Date: Mon, 8 Mar 2021 23:20:59 +0000 Subject: [PATCH 4/6] doc: use tags for true/false (not ) --- hpcgap/lib/filter.gi | 2 +- lib/bitfields.gd | 8 ++++---- lib/filter.gi | 2 +- lib/morpheus.gd | 2 +- lib/oper.g | 4 ++-- lib/system.g | 2 +- lib/teaching.g | 4 ++-- lib/test.gi | 4 ++-- lib/type.gd | 16 ++++++++-------- 9 files changed, 22 insertions(+), 22 deletions(-) diff --git a/hpcgap/lib/filter.gi b/hpcgap/lib/filter.gi index 8d30905296..d70e898d5e 100644 --- a/hpcgap/lib/filter.gi +++ b/hpcgap/lib/filter.gi @@ -24,7 +24,7 @@ ## position of this filter in the global FILTERS list. ##

## Note that not every filter for which IsFilter(filter) -## returns true has an ID, only elementary filters do. +## returns true has an ID, only elementary filters do. ## ## ## <#/GAPDoc> diff --git a/lib/bitfields.gd b/lib/bitfields.gd index 05be1683ac..b608fa7efa 100644 --- a/lib/bitfields.gd +++ b/lib/bitfields.gd @@ -53,13 +53,13 @@ ## corresponding to the width 1 fields. ## booleanGetters if the ith position of ## this list is set, it contains a function which extracts the ith -## field (which will have width one) and returns true if it contains 1 -## and false if it contains 0 +## field (which will have width one) and returns true if it contains 1 +## and false if it contains 0 ## booleanSetters if the ith position of ## this list is set, it contains a function of two arguments. The first -## argument is a packed value, the second is true or false. It returns a +## argument is a packed value, the second is true or false. It returns a ## new packed value in which the ith field is set to 1 if the second -## argument was true and 0 if it was false. Behaviour for any +## argument was true and 0 if it was false. Behaviour for any ## other value is undefined. ## ## diff --git a/lib/filter.gi b/lib/filter.gi index b2ea6c8eb9..71fef2d06c 100644 --- a/lib/filter.gi +++ b/lib/filter.gi @@ -24,7 +24,7 @@ ## position of this filter in the global FILTERS list. ##

## Note that not every filter for which IsFilter(filter) -## returns true has an ID, only elementary filters do. +## returns true has an ID, only elementary filters do. ## ## ## <#/GAPDoc> diff --git a/lib/morpheus.gd b/lib/morpheus.gd index 1905f51d24..2b82f2e955 100644 --- a/lib/morpheus.gd +++ b/lib/morpheus.gd @@ -364,7 +364,7 @@ DeclareGlobalFunction("MorMaxFusClasses"); ## condition ## ## A function that will be applied to the homomorphism and must return -## true for the homomorphism to be accepted. +## true for the homomorphism to be accepted. ## ## ##

diff --git a/lib/oper.g b/lib/oper.g index a47b256f68..70b4bf8f50 100644 --- a/lib/oper.g +++ b/lib/oper.g @@ -1244,9 +1244,9 @@ end ); ## this incremental rank (see ), ## ## If the argument mutable is the string "mutable" or -## the boolean true, then the values of the attribute are mutable. +## the boolean true, then the values of the attribute are mutable. ## -## If the argument mutable is the boolean false, then +## If the argument mutable is the boolean false, then ## the values of the attribute are immutable. ## ## diff --git a/lib/system.g b/lib/system.g index 207f995da9..198b2450ad 100644 --- a/lib/system.g +++ b/lib/system.g @@ -536,7 +536,7 @@ end); ## ## ## tests whether &GAP; is running on Mac OS X. Note that on Mac OS X, also -## will be true. +## will be true. ## ## ## <#/GAPDoc> diff --git a/lib/teaching.g b/lib/teaching.g index 9adc70030e..6ce07e688d 100644 --- a/lib/teaching.g +++ b/lib/teaching.g @@ -325,8 +325,8 @@ DeclareGlobalFunction("CheckDigitTestFunction"); ## ## These functions can be used to compute, or check, check digits for some ## everyday items. In each case what is submitted as input is either the number -## with check digit (in which case the function returns true or -## false), or the number without check digit (in which case the function +## with check digit (in which case the function returns true or +## false), or the number without check digit (in which case the function ## returns the missing check digit). The number can be specified as integer, as ## string (for example in case of leading zeros) or as a sequence of arguments, ## each representing a single digit. diff --git a/lib/test.gi b/lib/test.gi index c02a9de296..a498f4a91a 100644 --- a/lib/test.gi +++ b/lib/test.gi @@ -346,10 +346,10 @@ end); ## A #@if allows to conditionally skip parts of the test input depending on ## the value of a boolean expression. The exact behavior is done as follows: ##

-## If the &GAP; expression EXPR evaluates to true, then the lines after the +## If the &GAP; expression EXPR evaluates to true, then the lines after the ## #@if are used until either a #@else or #@fi is ## reached. If a #@else is present then the code after the #@else -## is used if and only if EXPR evaluated to false. Finally, +## is used if and only if EXPR evaluated to false. Finally, ## once #endif is reached, evaluation continues normally. ## ## diff --git a/lib/type.gd b/lib/type.gd index 6657d5b4e2..8177c58ac3 100644 --- a/lib/type.gd +++ b/lib/type.gd @@ -76,8 +76,8 @@ DeclareGlobalFunction( "TypeOfOperation" ); ## ## ## -## returns true if object is a category -## (see ), and false otherwise. +## returns true if object is a category +## (see ), and false otherwise. ##

## Note that &GAP; categories are not categories in the usual mathematical ## sense. @@ -97,8 +97,8 @@ DeclareGlobalFunction( "IsCategory" ); ## ## ## -## returns true if object is a representation -## (see ), and false otherwise. +## returns true if object is a representation +## (see ), and false otherwise. ## ## ## <#/GAPDoc> @@ -116,8 +116,8 @@ DeclareGlobalFunction( "IsRepresentation" ); ## ## ## -## returns true if object is an attribute -## (see ), and false otherwise. +## returns true if object is an attribute +## (see ), and false otherwise. ## ## ## <#/GAPDoc> @@ -135,8 +135,8 @@ DeclareGlobalFunction( "IsAttribute" ); ## ## ## -## returns true if object is a property -## (see ), and false otherwise. +## returns true if object is a property +## (see ), and false otherwise. ## ## ## <#/GAPDoc> From 1dafe9c98ae3a50bb38ce68edeffd2a78f090c13 Mon Sep 17 00:00:00 2001 From: Wilf Wilson Date: Tue, 26 Jan 2021 14:47:39 +0000 Subject: [PATCH 5/6] Fix assorted typos --- .github/issue_template.md | 2 +- .github/pull_request_template.md | 2 +- CHANGES.md | 2 +- dev/MODULE-PROPOSAL | 2 +- dev/MODULES | 24 ++++++++++++------------ dev/listarith.tex | 4 ++-- dev/modules.txt | 2 +- lib/grppcaut.gi | 2 +- lib/matrix.gi | 6 +++--- lib/sgpres.gi | 2 +- src/gap.c | 2 +- tst/mockpkg/doc/about.tex | 2 +- tst/testbugfix/2019-07-15-StoredInv.tst | 4 ++-- tst/teststandard/helptools.tst | 2 +- 14 files changed, 29 insertions(+), 29 deletions(-) diff --git a/.github/issue_template.md b/.github/issue_template.md index e3eb885a6b..aa4493f861 100644 --- a/.github/issue_template.md +++ b/.github/issue_template.md @@ -1,5 +1,5 @@ Please use the following template to submit an issue -(you may delete lines which are not used). Thank You! +(you may delete lines which are not used). Thank you! ### Observed behaviour diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 48f6a842e9..5a7131d08b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,6 @@ Please use the following template to submit a pull request, filling in at least the "Text for release notes" and/or "Further details". -Thank You! +Thank you! # Description diff --git a/CHANGES.md b/CHANGES.md index 504e46fd2c..ceb5ed00cb 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -352,7 +352,7 @@ The GAP 4.11.1 distribution contains 151 packages, of which 49 have been updated - [#3103](https://github.com/gap-system/gap/pull/3103) This fixes [#3097](https://github.com/gap-system/gap/issues/3097), a problem with `Order` of automorphism and [#3100](https://github.com/gap-system/gap/issues/3100), a problem with `GroupHomomorphismByImages` - [#3392](https://github.com/gap-system/gap/pull/3392) Prevent blist functions that modify an argument in-place (such as `UniteBlist`) from modifying immutable blists -- [#3522](https://github.com/gap-system/gap/pull/3522) `IsSimpleGroup` does not implies `IsAlmostSimpleGroup` anymore +- [#3522](https://github.com/gap-system/gap/pull/3522) `IsSimpleGroup` does not imply `IsAlmostSimpleGroup` anymore - [#3575](https://github.com/gap-system/gap/pull/3575) Fix bug in calculating x/p for an integer x and permutation p, if p has been 'trimmed'. - [#3603](https://github.com/gap-system/gap/pull/3603) Fix bug where the result of `StandardAssociateUnit` could be not a unit. - [#3611](https://github.com/gap-system/gap/pull/3611) Fix `StandardAssociateUnit` for polynomial rings to return a polynomial, not an element of the coefficient ring diff --git a/dev/MODULE-PROPOSAL b/dev/MODULE-PROPOSAL index 460d7ac5dc..2c8f46758b 100644 --- a/dev/MODULE-PROPOSAL +++ b/dev/MODULE-PROPOSAL @@ -4,7 +4,7 @@ A module is a part of GAP that - consists of a discrete set of files [unless there is a very good reason] - has a well-defined set of authors/maintainers. - - get credited separately (see below) + - gets credited separately (see below) Typical examples would be: - Rational functions - Lie Algebras diff --git a/dev/MODULES b/dev/MODULES index 3d0fe32acf..a7c9e62f12 100644 --- a/dev/MODULES +++ b/dev/MODULES @@ -239,7 +239,7 @@ Authors: Bettina Eick Maintainers: Werner Nickel Description: This module contains an algorithm to determine the automorphism group of a finite pc group. The implementation follows the ideas - of Micheal Smith. + of Michael Smith. Name: Twocohomology and extensions of finite pc groups Proposer: Bettina Eick @@ -322,7 +322,7 @@ Authors: Andrew Solomon, Robert F. Morse Maintainer: Robert F. Morse Description: This library code computes congruences for a set with one binary operator. Faster methods are used when - associativity is known. + associativity is known. Name: Semigroup relations Proposer: Robert F. Morse 21-May-01 @@ -376,16 +376,16 @@ Authors: Burkhard Hšfling Description: This set of files provides the implementation of system dependent GAP functions and a user interface to run GAP under MacOS -Name: Identification of Galois groups -Proposer: Alexander Hulpke -Seconder: Frank Lübeck (May 4, 2003), Joachim Neub"user (May 5, 2003) -Files: galois.g* -Author&Maintainer: Alexander Hulpke -Description: functionality for determining the permutation isomorphism type of a Galois group. +Name: Identification of Galois groups +Proposer: Alexander Hulpke +Seconder: Frank Lübeck (May 4, 2003), Joachim Neubüser (May 5, 2003) +Files: galois.g* +Author&Maintainer: Alexander Hulpke +Description: functionality for determining the permutation isomorphism type of a Galois group. Name: Characters and Character Degrees of certain solvable groups Proposer: Thomas Breuer -Seconder: Frank Lübeck (July 15, 2003), Joachim Neub"user (July 15, 2003) +Seconder: Frank Lübeck (July 15, 2003), Joachim Neubüser (July 15, 2003) Files: lib/ctblsolv.gd, lib/ctblsolv.gi Authors: Hans Ulrich Besche, Thomas Breuer Maintainer: Thomas Breuer @@ -397,7 +397,7 @@ Description: Computation of irreducible character degrees of solvable groups, Name: Possible Permutation Characters Proposer: Thomas Breuer -Seconder: Frank Lübeck (July 31, 2003), Joachim Neub"user (June 17, 2003) +Seconder: Frank Lübeck (July 31, 2003), Joachim Neubüser (June 17, 2003) Files: lib/ctblpope.gd, lib/ctblpope.gi, sections ``Possible Permutation Characters'' and ``Computing Possible Permutation Characters'' in @@ -410,7 +410,7 @@ Description: Computation of characters that have certain properties of Name: Monomiality Questions Proposer: Thomas Breuer -Seconder: Frank Lübeck (July 31, 2003), Joachim Neub"user (June 17, 2003) +Seconder: Frank Lübeck (July 31, 2003), Joachim Neubüser (June 17, 2003) Files: lib/ctblmono.gd, lib/ctblmono.gi, doc/build/ctblmono.msk, tst/ctblmono.tst Authors: Thomas Breuer, Erzsébet Horváth @@ -419,7 +419,7 @@ Description: Monomiality of finite (solvable) groups and their characters Name: Possible Class Fusions, Possible Power Maps Proposer: Thomas Breuer -Seconder: Frank Lübeck (July 31, 2003), Joachim Neub"user (June 17, 2003) +Seconder: Frank Lübeck (July 31, 2003), Joachim Neubüser (June 17, 2003) Files: lib/ctblmaps.gd, lib/ctblmaps.gi, doc/build/ctblmaps.msk Authors: Thomas Breuer Maintainer: Thomas Breuer diff --git a/dev/listarith.tex b/dev/listarith.tex index 31c8ec51d8..ca828243b0 100644 --- a/dev/listarith.tex +++ b/dev/listarith.tex @@ -123,7 +123,7 @@ \subsection{In vector.c and vecffe.c} \section{XTNum extended despatch} -XTNum is defined in lists.c. It's behaviour is controlled by entries +XTNum is defined in lists.c. Its behaviour is controlled by entries in the IsXTNumListFuncs jump table. These are boolean (C style) unctions, possibly defined for types from \verb|FIRST_REAL_TNUM| up to \verb|LAST_REAL_TNUM|. Each one is tried in reverse TNUM order, with @@ -258,7 +258,7 @@ \section{Determining the Type of Plists} What is relevant for our purposes, is that this code, taking advantage of the information already stored about the list, walks the structure -of it, as far as necessary to determine it's ``transient'' TNUM (ie +of it, as far as necessary to determine its ``transient'' TNUM (ie the TNUM that it really deserves, but which might not be storable thanks to the presence of mutable subobjects) storing as much information along the way as it can. After that, the type is just diff --git a/dev/modules.txt b/dev/modules.txt index 9062ea6ca1..7f8bc23246 100644 --- a/dev/modules.txt +++ b/dev/modules.txt @@ -5,7 +5,7 @@ also put in a file `dev/modules.txt' Modularization of GAP ====================== -There are three levels of ``separateness'', that are roughly conatined in +There are three levels of ``separateness'', that are roughly contained in each other: The first is a purely software engineering level of ``Modules''. A module is a piece of code which provides certain functionality via a defined set of diff --git a/lib/grppcaut.gi b/lib/grppcaut.gi index ac068e7256..2405621d03 100644 --- a/lib/grppcaut.gi +++ b/lib/grppcaut.gi @@ -786,7 +786,7 @@ end; # construct subgroup of GL that stabilizes the spaces given and fixes the # listed spaceorbits. -# auxillary +# auxiliary RedmatSpanningIndices:=function(gens) local bas,n,one,new,a,b,g; n:=Length(gens[1]); diff --git a/lib/matrix.gi b/lib/matrix.gi index 07110f2a27..3a391f492e 100644 --- a/lib/matrix.gi +++ b/lib/matrix.gi @@ -1551,7 +1551,7 @@ InstallMethod( DeterminantMatDestructive,"nonprime residue rings", ## Mahajan and Vinay \cite{MV97}. ## ## The run time is $O(n^4)$ -## Auxillary storage size $n^2+n + C$ +## Auxiliary storage size $n^2+n + C$ ## ## Our implementation has two runtime optimizations (both noted ## by Mahajan and Vinay) @@ -1560,9 +1560,9 @@ InstallMethod( DeterminantMatDestructive,"nonprime residue rings", ## 2. Prefix property is maintained allowing for a pruning of many ## vertices at each level ## -## and two auxillary storage size optimizations +## and two auxiliary storage size optimizations ## 1. only the upper triangular and diagonal portion of the -## auxillary storage is used. +## auxiliary storage is used. ## 2. Level information storage is reused (2 levels). ## ## This code was implemented by: diff --git a/lib/sgpres.gi b/lib/sgpres.gi index 47c5036a91..6098536f00 100644 --- a/lib/sgpres.gi +++ b/lib/sgpres.gi @@ -3579,7 +3579,7 @@ local DATA,rels,i,j,w,f,r,s,fam,new,ri,a,offset,p,rset,re,start,stack,pres, if warn and Length(s)>100*Sum(rels,Length) then warn:=false; Error( - "Trying to eliminate all auxillary generators might cause the\n", + "Trying to eliminate all auxiliary generators might cause the\n", "size of the presentation to explode. Proceed at risk!"); fi; od; diff --git a/src/gap.c b/src/gap.c index 8c0d8c33bb..b25efd4964 100644 --- a/src/gap.c +++ b/src/gap.c @@ -1445,7 +1445,7 @@ StructInitInfo * InitInfoGap ( void ) ** function is used for both starting and restoring. ** ** `InitLibrary': This function creates objects, gvar and rnam number, and -** does assignments of auxillary C variables (for example, pointers from +** does assignments of auxiliary C variables (for example, pointers from ** objects, length of hash lists). This function is only used for starting. ** ** `PostRestore': Everything in `InitLibrary' execpt creating objects. In diff --git a/tst/mockpkg/doc/about.tex b/tst/mockpkg/doc/about.tex index 9eae815848..034794f1e9 100644 --- a/tst/mockpkg/doc/about.tex +++ b/tst/mockpkg/doc/about.tex @@ -8,7 +8,7 @@ This is a mock package to be used to test {\GAP} library code related to {\GAP} packages, for example to validate `PackageInfo.g` -files. Clearly, it's not available anywhere, and it has it's `ArchiveURL' set +files. Clearly, it's not available anywhere, and it has its `ArchiveURL' set to `Concatenation( ~.PackageWWWHome, "/", ~.PackageName, "-", ~.Version )' only for testing purposes. diff --git a/tst/testbugfix/2019-07-15-StoredInv.tst b/tst/testbugfix/2019-07-15-StoredInv.tst index ce748445ee..97ef609f3e 100644 --- a/tst/testbugfix/2019-07-15-StoredInv.tst +++ b/tst/testbugfix/2019-07-15-StoredInv.tst @@ -27,7 +27,7 @@ true gap> IsPerm4Rep(q); true -# and it's inverse is the correct type +# and its inverse is the correct type gap> IsPerm4Rep(q^-1); true @@ -35,6 +35,6 @@ true gap> List([1..5], x -> x/p); [ 4, 1, 2, 3, 5 ] -# And on q (to ensure it's inverse is not still 'p') +# And on q (to ensure its inverse is not still 'p') gap> List([1..5], x -> x/q); [ 2, 3, 4, 1, 5 ] diff --git a/tst/teststandard/helptools.tst b/tst/teststandard/helptools.tst index fca48aedd1..3976e86b78 100644 --- a/tst/teststandard/helptools.tst +++ b/tst/teststandard/helptools.tst @@ -67,7 +67,7 @@ gap> PrintRenderedText(1,1 ); % % This is a mock package to be used to test GAP library code related to GAP % packages, for example to validate `PackageInfo.g` files. Clearly, it's -% not available anywhere, and it has it's `ArchiveURL' set to +% not available anywhere, and it has its `ArchiveURL' set to % `Concatenation( ~.PackageWWWHome, "/", ~.PackageName, "-", ~.Version )' % only for testing purposes. % From eb973d76222b76f32283c800d91fa76fe843cfc0 Mon Sep 17 00:00:00 2001 From: Wilf Wilson Date: Mon, 18 Nov 2019 11:37:57 +0100 Subject: [PATCH 6/6] Switch an error msg away from using "i." Although the new text is longer, I think it's more understandable in English, in general, than the more German notation "i.". --- src/gap.c | 4 ++-- tst/testinstall/kernel/gap.tst | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gap.c b/src/gap.c index b25efd4964..b1836a4d19 100644 --- a/src/gap.c +++ b/src/gap.c @@ -590,8 +590,8 @@ static Obj FuncWindowCmd(Obj self, Obj args) { tmp = ELM_LIST( args, i ); if (!IS_INTOBJ(tmp) && !IsStringConv(tmp)) { - ErrorMayQuit("WindowCmd: %d. argument must be a string or integer " - "(not a %s)", + ErrorMayQuit("WindowCmd: the argument in position %d must be a " + "string or integer (not a %s)", i, (Int)TNAM_OBJ(tmp)); SET_ELM_PLIST(args, i, tmp); } diff --git a/tst/testinstall/kernel/gap.tst b/tst/testinstall/kernel/gap.tst index 20e24eacc5..7d6313625e 100644 --- a/tst/testinstall/kernel/gap.tst +++ b/tst/testinstall/kernel/gap.tst @@ -79,8 +79,8 @@ Error, WindowCmd: must be a string (not the value 'fail') gap> WindowCmd([""]); Error, WindowCmd: must be a string of length 3 gap> WindowCmd(["abc",fail]); -Error, WindowCmd: 2. argument must be a string or integer (not a boolean or fa\ -il) +Error, WindowCmd: the argument in position 2 must be a string or integer (not \ +a boolean or fail) gap> WindowCmd(["abc"]); Error, window system: No Window Handler Present gap> WindowCmd(["abc",1,"foo"]);