Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Reset should state that it returns the previous RNG seed #4109

Closed
fingolfin opened this issue Sep 4, 2020 · 1 comment
Closed
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development topic: documentation Issues and PRs related to documentation

Comments

@fingolfin
Copy link
Member

Some code even seems to rely on that.

Might be a good idea to verify all implementations do this (I am aware of only one implementation outside of GAP itself, namely in the io package).

@fingolfin fingolfin added good first issue Issues that can be understood and addressed by newcomers to GAP development topic: documentation Issues and PRs related to documentation labels Sep 4, 2020
@jackschmidt
Copy link
Contributor

I believe this was fixed in #4438

I checked through the packages on an installation of GAP 4.11.1 (ubuntu 20.10) and only found three instances:

  • 👍 xgap defined a Reset operation on a different type of object (text selection user interface object)
  • 👍 orb defined a Reset operation on a different type of object (product replacer)
  • 🤷 io defines a Reset operation on a IsRandomSource, but it does not do anything since the random source is not meant to be reproducible. It does not return any value, but I don't think there is a sensible value to return.

None of them allow setting a "seed" or anything like that, so I don't think there is any danger of confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development topic: documentation Issues and PRs related to documentation
Projects
None yet
Development

No branches or pull requests

2 participants