-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAP should not require PrimgGrp/SmallGrp/TransGrp packages #2434
Comments
Started work on this via #2589, but I am pretty sure tons of packages need changes... E.g. lots of packages use Just to get a first rough approximation of which packages might be affected, I did some very simple grepping to get a first approximation of the issue (note that will be both false positives and false negatives with this method): Packages which seem to use
Packages which seem to use
Packages which seem to use
We could now go through these packages, and update the above check lists once we know the package either declares suitable dependencies, or has been fixed, or was never really affected in the first place (ideally leave a comment stating which it was) All in all, this is a big bunch of packages, so we'd need a good plan on how to approach this if we want to resolve it in time for GAP 4.10... May need to punt this to a later release otherwise. |
This won't be in 4.10; not even sure that it realistically can be in 4.11, but I bumped it to that milestone anyway. |
Removed this from the 4.11 milestone. I don't think we can do this in time, and in fact, I am not sure it'll ever happen, it just isn't worth the effort compared to many other more pressing issues. That said, if anybody wants to help with this: pick one (or multiple!) of the packages on the list above; check whether it really needs any of the functionality of PrimgGrp/SmallGrp/TransGrp ; if no, state so here (and check its checkbox); if yes, provide a pull request to that package which adds the dependency to that package's |
I should also point out that the GAP library itself uses these packages, e.g.
|
Erm... should this ever happen at all? |
The libraries of small, primitive and transitive groups which previously were an integral part of ⪆ were split into three separate packages:
For backwards compatibility, these are required packages in GAP 4.9 (i.e., GAP will not start without them). We plan to change this for GAP 4.10, once all packages which currently implicitly rely on these new packages had time to add explicit dependencies on them.
This issue under the milestone 4.10 is created to track this:
The text was updated successfully, but these errors were encountered: