Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GAP_KERNEL_API_VERSION in configure.ac, use it to modify GAPARCH #2390

Closed
fingolfin opened this issue Apr 23, 2018 · 1 comment
Closed
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: build system topic: kernel

Comments

@fingolfin
Copy link
Member

Currently, we #define GAP_KERNEL_API_VERSION in src/modules.h, with the idea being that we increment it when there are kernel API / ABI changes that cause incompatibilities.

We should consider changing this so that we set the API/ABI version in configure.ac, and then propagate this to src/modules.h. This has the advantage that we can, in the future, use this to adapt how libgap shared library is built and named. Moreover, we can use it to modify the GAPARCH string; this then will cause kernel extensions in packages to be built in a different directory, which in turn is useful if one is using several mutually incompatible GAP versions in parallel.

I can't think of any drawbacks right now.

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: build system topic: kernel labels Apr 23, 2018
@dimpase dimpase removed topic: libgap things related to libgap labels Oct 31, 2018
@fingolfin
Copy link
Member Author

Done in PR #2873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: build system topic: kernel
Projects
None yet
Development

No branches or pull requests

2 participants