Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow in table of terminated processes #1849

Closed
olexandr-konovalov opened this issue Nov 2, 2017 · 3 comments
Closed

Overflow in table of terminated processes #1849

olexandr-konovalov opened this issue Nov 2, 2017 · 3 comments
Labels
kind: bug Issues describing general bugs, and PRs fixing them
Milestone

Comments

@olexandr-konovalov
Copy link
Member

This currently happens in the master branch. @ChrisJefferson is working on it already, I am recording it to remember. This is needed for GAP 4.9 beta, as it fails `make testbugfix' test.

########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-master-test/GAPCOPT\
S/64build/GAPTARGET/bugfix/label/kovacs/GAP-master-snapshot/tst/testbugfix/201\
7-10-20-runprocess.tst:44
# Input is:
 for i in [1..1000] do func2(); od;
# Expected output:
# But found:
#E Overflow in table of terminated processes
#E Overflow in table of terminated processes
#E Overflow in table of terminated processes
#E Overflow in table of terminated processes
...
@olexandr-konovalov olexandr-konovalov added the kind: bug Issues describing general bugs, and PRs fixing them label Nov 2, 2017
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Nov 2, 2017
@ChrisJefferson
Copy link
Contributor

Plan for fixing this bug (it's going to be in multiple piecesc)

  1. Add a hook into GAP so libraries can report children which have died ( Fix the interaction of signals in GAP and the IO package #1851 , ready for merging )

  2. Use that hook in IO ( Pass signals about dead child processes to GAP gap-packages/io#55 - proof of principle, needs documentation and tests )

@olexandr-konovalov
Copy link
Member Author

For now, @ChrisJefferson in #1910 makes the process test pass by disabling the IO signal handler. This would have to be revisited after the next IO release.

@olexandr-konovalov
Copy link
Member Author

Fixed now in #1851 in combination with IO 4.5.0 release. Thanks @ChrisJefferson @fingolfin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
Development

No branches or pull requests

2 participants