Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject broken symlinks or even all #95

Open
fingolfin opened this issue Jan 18, 2023 · 2 comments
Open

Reject broken symlinks or even all #95

fingolfin opened this issue Jan 18, 2023 · 2 comments

Comments

@fingolfin
Copy link
Member

See gap-system/gap#5285

@fingolfin fingolfin changed the title Reject broken symlinks Reject broken symlinks or even all Jan 19, 2023
@fingolfin
Copy link
Member Author

Perhaps we should just forbid all symlinks; that's easier to test for, and matches what the package distro does, see gap-system/PackageDistro@ae62ac6

@fingolfin
Copy link
Member Author

Note that anyone installing GAP via Debian and then using that to make a GAP package release will likely get a bad symlink doc/mathjax due to this patch to GAPDoc applied in the Debian package... I didn't verify it but it seems likely that this also affects the Ubuntu package and any other package based on the Debian one.

This is quite unfortunate. We can't just fix this by removing the doc/mathjax file either, also the HTML files need to be adjusted to not reference it (basically undoing the changes introduced by the referenced patch.

Someone should also email Bill Allombert, the maintainer of the package, and kindly ask him whether he might undo that patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant