Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffs in tests dependently on loaded packages #11

Closed
olexandr-konovalov opened this issue Oct 1, 2018 · 1 comment
Closed

Diffs in tests dependently on loaded packages #11

olexandr-konovalov opened this issue Oct 1, 2018 · 1 comment

Comments

@olexandr-konovalov
Copy link
Member

New SONATA release picked up and it is compatible with GAP - thanks @PMayr and @fingolfin!

The next step could be to adjust tests to make them more reproducible. It happened that in stable-4.10 branch tests pass when GAP is started with -A, but have diffs when default or all packages are loaded:

########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-pkg-update-stable-q\
uicktest/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-u\
pdate-stable-snapshot/pkg/sonata-2.9/tst/ideals.tst:20
# Input is:
nsgps := NormalSubgroups( a );
# Expected output:
[ Group(()), Group([ (1,3)(2,4) ]), Group([ (1,3)(2,4), (1,2)(3,4) ]), 
  Group([ (1,3)(2,4), (2,4) ]), Group([ (1,2,3,4), (1,3)(2,4) ]), 8/4 ]
# But found:
[ 8/4, Group([ (1,2,3,4), (1,3)(2,4) ]), Group([ (1,4)(2,3), (1,3)(2,4) ]), 
  Group([ (2,4), (1,3)(2,4) ]), Group([ (1,3)(2,4) ]), Group(()) ]
########
########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-pkg-update-stable-q\
uicktest/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-u\
pdate-stable-snapshot/pkg/sonata-2.9/tst/ideals.tst:23
# Input is:
l := Filtered( nsgps,                                             
s -> IsSubgroupNearRingRightIdeal( n, s ) );
# Expected output:
[ Group(()), Group([ (1,3)(2,4), (2,4) ]), 8/4 ]
# But found:
[ 8/4, Group([ (2,4), (1,3)(2,4) ]), Group(()) ]
########
########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-pkg-update-stable-q\
uicktest/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-u\
pdate-stable-snapshot/pkg/sonata-2.9/tst/ideals.tst:47
# Input is:
Filtered( NearRingIdeals( n ), IsPrimeNearRingIdeal );
# Expected output:
[ < nearring ideal of size 9 >, < nearring ideal of size 27 > ]
# But found:
[ < nearring ideal of size 27 >, < nearring ideal of size 9 > ]
########
########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-pkg-update-stable-q\
uicktest/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-u\
pdate-stable-snapshot/pkg/sonata-2.9/tst/ideals.tst:62
# Input is:
List( i, Size );
# Expected output:
[ 1, 6 ]
# But found:
[ 6, 1 ]
########
########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-pkg-update-stable-q\
uicktest/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-u\
pdate-stable-snapshot/pkg/sonata-2.9/tst/ideals.tst:64
# Input is:
NearRingCommutator( i[2], i[2] );
# Expected output:
< nearring ideal of size 6 >
# But found:
< nearring ideal >
########
########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-pkg-update-stable-q\
uicktest/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-u\
pdate-stable-snapshot/pkg/sonata-2.9/tst/ideals.tst:203
# Input is:
List(I,Size);
# Expected output:
[ 1, 6, 12 ]
# But found:
[ 12, 6, 1 ]
########

Probably you need to sort the output of the first command e.g. by the order of the subgroup, to ensure that they are always used for the test in the same order?

@PMayr
Copy link
Collaborator

PMayr commented Oct 2, 2018

Thanks a lot for the new release! I sorted the above list results in ideals.tst but I am not sure whether still some differences show up in certain settings. Please let me know if anything else is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants