Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behaviour between AbelianPcpGroup and AbelianGroupCons #50

Open
stertooy opened this issue Aug 5, 2020 · 0 comments
Open

Comments

@stertooy
Copy link
Contributor

stertooy commented Aug 5, 2020

IMHO, it seems weird that AbelianPcpGroup and AbelianGroupCons share the same purpose and share a lot of code, but behave differently for certain inputs. For example, if the input contains a negative integer, we have:

gap> AbelianPcpGroup([-1,2,3]);
Pcp-group with orders [ 0, 2, 3 ]
gap> AbelianGroupCons(IsPcpGroup,[-1,2,3]);
Error, no method found! For debugging hints type ?Recovery from NoMethodFound

Since both functions share a lot of code, perhaps one could call the other? This would also prevent situations like #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant