Diffs in tests under GAP stable-4.10 branch

[olexandr-konovalov]

https://travis-ci.org/gap-system/gap-docker-pkg-tests-stable-4.10-staging/jobs/438054209 reports some diffs (1 or 4, dependently on how many packages are loaded). This will be useful to fix in October to get into the coming GAP 4.10 release.

testing: /home/gap/inst/gap-stable-4.10/pkg/cryst/tst/cryst.tst
########> Diff in /home/gap/inst/gap-stable-4.10/pkg/cryst/tst/cryst.tst:175
# Input is:
g := PreImage(iso, h);
# Expected output:
[ [ 1, 0, 0, 0 ], [ 0, 0, 1, 0 ], [ 0, -1, 0, 0 ], [ -7/4, 5/4, 3/4, 1 ] ]
# But found:
[ [ 0, -1, 0, 0 ], [ -1, 0, 0, 0 ], [ 0, 0, -1, 0 ], [ -1/4, 3/4, 3/4, 1 ] ]
########
########> Diff in /home/gap/inst/gap-stable-4.10/pkg/cryst/tst/cryst.tst:314
# Input is:
NaturalHomomorphismByNormalSubgroup( G, K );
# Expected output:
CompositionMapping( [ g1, g2, g3, g4, g5, g6, g7 ] -> 
[ g1, g2, g3, g4, id, id, id ], 
[ [ [ 1, 0, 0, 0 ], [ 0, 0, 1, 0 ], [ 0, -1, 0, 0 ], [ -7/4, 5/4, 3/4, 1 ] ]
    , [ [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 1, 0, 0, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, -1, 0, 0 ], [ 0, 0, -1, 0 ], [ -1/2, -1/2, 1, 1 ] ]
    , 
  [ [ -1, 0, 0, 0 ], [ 0, -1, 0, 0 ], [ 0, 0, 1, 0 ], [ 1/2, 0, -1/2, 1 ] ],
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 1/2, 1/2, 1/2, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 0, 1, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 0, 0, 1, 1 ] ] ] -> 
[ g1, g2, g3, g4, g5, g6, g7 ] )
# But found:
CompositionMapping( [ g1, g2, g3, g4, g8, g5, g6, g7, g8^2, g9, g10 ] -> 
[ g1, g2, g3, g4, g5, id, id, id, id, id, id ], 
[ [ [ 0, -1, 0, 0 ], [ -1, 0, 0, 0 ], [ 0, 0, -1, 0 ], [ -1/4, 3/4, 3/4, 1 ] ]
    , [ [ 0, 0, 1, 0 ], [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 3, -2, 1, 1 ] ], 
  [ [ -1, 0, 0, 0 ], [ 0, -1, 0, 0 ], [ 0, 0, 1, 0 ], [ -7/2, 0, -3/2, 1 ] ], 
  [ [ -1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, -1, 0 ], [ 0, -3/2, -7/2, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 0, 1, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 1, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 0, 0, 1, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ -3/2, -3/2, -3/2, 1 ] ],
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 0, -3, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ -3, 0, 0, 1 ] ] ] -> 
[ g1, g2, g3, g4, g5, g6, g7, g8, g9, g10 ] )
########
########> Diff in /home/gap/inst/gap-stable-4.10/pkg/cryst/tst/cryst.tst:330
# Input is:
NaturalHomomorphismByNormalSubgroup( G, K );
# Expected output:
CompositionMapping( [ g1, g2, g3, g4, g5, g6, g7, g8 ] -> 
[ g1, g2, g3, g4, g5, id, id, id ], 
[ [ [ -1, 0, 0, 0 ], [ 0, 1, 0, 1/2 ], [ 0, 0, 1, 1/2 ], [ 0, 0, 0, 1 ] ], 
  [ [ 0, 0, 1, 0 ], [ 0, 1, 0, 0 ], [ -1, 0, 0, 1/2 ], [ 0, 0, 0, 1 ] ], 
  [ [ 0, 0, 1, 0 ], [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ -1, 0, 0, 1/2 ], [ 0, 1, 0, 0 ], [ 0, 0, -1, 1/2 ], [ 0, 0, 0, 1 ] ], 
  [ [ -1, 0, 0, 1/2 ], [ 0, -1, 0, 1/2 ], [ 0, 0, 1, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 1 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 1 ], [ 0, 0, 1, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 1 ], [ 0, 0, 0, 1 ] ] ] -> 
[ g1, g2, g3, g4, g5, g6, g7, g8 ] )
# But found:
CompositionMapping( [ g1, g2, g3, g4, g5, g6, g7, g8, g9, g10, g11 ] -> 
[ g1, g2, g3, g4, g5, id, id, id, id, id, id ], 
[ [ [ 0, -1, 0, 1/2 ], [ -1, 0, 0, 1/2 ], [ 0, 0, -1, 1/2 ], [ 0, 0, 0, 1 ] ],
  [ [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 1, 0, 0, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ -1, 0, 0, 1/2 ], [ 0, -1, 0, 1/2 ], [ 0, 0, 1, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, -1, 0, 1/2 ], [ 0, 0, -1, 1/2 ], [ 0, 0, 0, 1 ] ], 
  [ [ -1, 0, 0, 0 ], [ 0, -1, 0, 0 ], [ 0, 0, -1, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 1 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 1 ], [ 0, 0, 1, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 1 ], [ 0, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 3 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 3 ], [ 0, 0, 1, 0 ], [ 0, 0, 0, 1 ] ], 
  [ [ 1, 0, 0, 0 ], [ 0, 1, 0, 0 ], [ 0, 0, 1, 3 ], [ 0, 0, 0, 1 ] ] ] -> 
[ g1, g2, g3, g4, g5, g6, g7, g8, g9, g10, g11 ] )
########
   27756 ms (1760 ms GC) and 2.60GB allocated for cryst.tst
testing: /home/gap/inst/gap-stable-4.10/pkg/cryst/tst/manual.tst
########> Diff in /home/gap/inst/gap-stable-4.10/pkg/cryst/tst/manual.tst:189
# Input is:
sub := AffineInequivalentSubgroups( S, sub );
# Expected output:
[ <matrix group of size infinity with 4 generators>, 
  <matrix group of size infinity with 3 generators> ]
# But found:
[ <matrix group with 4 generators>, <matrix group with 3 generators> ]
########
    1168 ms (316 ms GC) and 97.9MB allocated for manual.tst
testing: /home/gap/inst/gap-stable-4.10/pkg/cryst/tst/subgrp.tst
   14708 ms (1136 ms GC) and 1.39GB allocated for subgrp.tst
testing: /home/gap/inst/gap-stable-4.10/pkg/cryst/tst/wyckoff.tst
    4684 ms (604 ms GC) and 413MB allocated for wyckoff.tst
testing: /home/gap/inst/gap-stable-4.10/pkg/cryst/tst/zass.tst
    4352 ms (608 ms GC) and 365MB allocated for zass.tst
-----------------------------------
total     52668 ms (4424 ms GC) and 4.85GB allocated
#I  Errors detected while testing
============================OUTPUT END================================

[gaehler]

What was being tested here - the released version 4.1.17 of cryst? It seems to me that most of these issues were already addressed in the developement version. Anyway, I have made a new release 4.1.18, which should fix the above issues.

[olexandr-konovalov]

Yes, that is a test of the released version (for the latest test of the development version with default packages loaded, see https://travis-ci.org/gap-packages/gap-docker-pkg-tests-stable-4.10-devel/jobs/445082919 - it passes there). Good to prepare a new release, thanks!

[olexandr-konovalov]

All diffs are gone - thanks: https://travis-ci.org/gap-system/gap-docker-pkg-tests-stable-4.10-staging/jobs/446654836