The empty semigroup is not monogenic #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wilfwilson this seems to cause some of the GAP tests to fail. Any thoughts? |
wilfwilson
force-pushed
the
empty-semigroup-is-not-monogenic
branch
2 times, most recently
from
8fd0a04 to
7f1b54d
Compare
wilfwilson
force-pushed
the
empty-semigroup-is-not-monogenic
branch
from
7f1b54d to
4cf4d51
Compare
|
@james-d-mitchell the test failures were unrelated to this PR, and were caused by first this gap-system/gap#3052 and then this gap-system/gap#3053 being merged into GAP master. For the first, this caused our So (having changed nothing about this PR), the tests on this should pass now. |
|
Thanks @wilfwilson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an empty semigroup is set to be monogenic by an immediate method. But I don't think that it should count as monogenic: its rank isn't 1, and there exists no element inside the empty semigroup that generates the empty semigroup.
I know that we normally avoid empty semigroups, and for certain properties it's probably not very clear whether the empty semigroup has that property. But here I think it's clear so we may as well fix it.