Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArticulationPoints duplicate vertices #140

Closed
le27 opened this issue Oct 17, 2018 · 3 comments
Closed

ArticulationPoints duplicate vertices #140

le27 opened this issue Oct 17, 2018 · 3 comments
Labels
bug A label for issues that are bugs

Comments

@le27
Copy link
Collaborator

le27 commented Oct 17, 2018

The articulation points function can return repeats of the same vertex. In the following example the vertex 30 is returned twice and the vertex 61 is returned 3 times:

gap> gr:=DigraphFromSparse6String(
> ":~?@V`OINBg_McouHAxQD@gyYEW}Q_@_YdgE`?OgZgpEbfYQKDGqiDQEI`wGdjoADGZG\
FIJONFQSplq]y@IwvbPKhMh}JGK?OLzW{agKKfRCtarqTGayQGb]rMIurapkxPG?RGcI]\
IBtB_`EQKJ@LmxlL_?k^QieOkB|T");
<digraph with 87 vertices, 214 edges>
gap> ArticulationPoints(gr);
[ 30, 27, 30, 23, 21, 63, 12, 73, 52, 75, 84, 11, 17, 60, 19, 87, 15, 69, 76, 42, 61, 59, 61, 66, 61, 68, 8, 51, 41, 37, 36, 18, 79, 3, 
  46, 1 ]
gap> SortedList(ArticulationPoints(gr));
[ 1, 3, 8, 11, 12, 15, 17, 18, 19, 21, 23, 27, 30, 30, 36, 37, 41, 42, 46, 51, 52, 59, 60, 61, 61, 61, 63, 66, 68, 69, 73, 75, 76, 79, 
  84, 87 ]
@james-d-mitchell james-d-mitchell added bug A label for issues that are bugs 0.13 labels Oct 17, 2018
@james-d-mitchell
Copy link
Member

I can reproduce this, and will investigate.

@james-d-mitchell
Copy link
Member

It looks like all the vertices returned are articulation points at least.

james-d-mitchell pushed a commit to james-d-mitchell/Digraphs that referenced this issue Oct 18, 2018
@james-d-mitchell james-d-mitchell added the resolved-pending-merge A label for issues that are resolved in a PR that is not yet merged. label Oct 18, 2018
james-d-mitchell pushed a commit to james-d-mitchell/Digraphs that referenced this issue Oct 18, 2018
wilfwilson pushed a commit that referenced this issue Nov 9, 2018
@wilfwilson wilfwilson added resolved-pending-release A label for issues that have been resolved and that can be closed when a new version is released. and removed resolved-pending-merge A label for issues that are resolved in a PR that is not yet merged. labels Nov 9, 2018
@wilfwilson
Copy link
Collaborator

Resolved in v0.14.0 release

@wilfwilson wilfwilson removed the resolved-pending-release A label for issues that have been resolved and that can be closed when a new version is released. label Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A label for issues that are bugs
Projects
None yet
Development

No branches or pull requests

3 participants