Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ecology] Changes sdm tut #3750

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Conversation

shiltemann
Copy link
Member

@shiltemann shiltemann commented Nov 10, 2022

This recreates the PR from #2964, but since the user has deleted their GitHub account, I cannot fix the merge conflicts or make changes on the original PR

ping @yvanlebras since you were going to test this

description from original PR:

I noticed an error with the column number 51 on the Cut section, the column option that worked for me was 54. I also noticed BISON was linked to gbif, so I changed that to their current url, however BISON does have a notice their website that they will be going dark this year and merging to gbif.us, so I wasn't sure if that should be kept or not.

I also noticed a few spelling and grammar errors so I changed them.

@shiltemann shiltemann requested a review from a team as a code owner November 10, 2022 16:34
@shiltemann shiltemann mentioned this pull request Nov 10, 2022
@yvanlebras
Copy link
Collaborator

THANK YOU very much Saskia! And thank you to the ""ghost"" contributor! Will try to look at it next week! The requested changes are not trivial, I need to verify it in details! Cheers!

@shiltemann
Copy link
Member Author

@yvanlebras going through old PRs and saw this one again, any more thoughts/input?

@yvanlebras
Copy link
Collaborator

THANK YOU Saskia! This is ok for me, but I think we need to come back to the GxIT as it seems to me it is not working properly if I remember a recent feedback

@hexylena hexylena merged commit b25ac98 into galaxyproject:main Nov 17, 2023
@hexylena
Copy link
Member

we'll merge it now and maybe we can address the gxit separately (I think theres's an issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants