Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new tool gene.iobio #5365
Add new tool gene.iobio #5365
Changes from all commits
9a58c95
c307232
d6015ae
3a37299
57f77c1
3d9361b
0e4a78a
73e1bfd
7ff5832
d0cd1f9
ceea879
d10ac65
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should be very clear that data is transferred to their servers, since maybe with an iframe it isn't immediately obvious. We could add a warning in the help text
(with the correct indentation of course)
alternatively maybe that could be a mandatory checkbox that the user has to check to acknowledge? I just worry with such a useful tool for human data someone makes a mistake a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in order to use the tool you'd need to make the history public right? I would say that's quite clear, but indeed we'll need to mention it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's true, we don't mention that somewhere, we should mention that as well.