-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new tool gene.iobio #5365
Add new tool gene.iobio #5365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some linting comments. I'm not sure we can write a sensible version command here without curl
which feels wrong.
<tests> | ||
</tests> | ||
<help><![CDATA[ | ||
Gene.iobio provides a report of impactful variants. Gene.iobio also helps prioritize variants based on multiple integrated gene:disease association algorithms and knowledge bases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should be very clear that data is transferred to their servers, since maybe with an iframe it isn't immediately obvious. We could add a warning in the help text
.. class:: Warning mark
This transfers data to a remote server, in US jurisdiction
(with the correct indentation of course)
alternatively maybe that could be a mandatory checkbox that the user has to check to acknowledge? I just worry with such a useful tool for human data someone makes a mistake a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in order to use the tool you'd need to make the history public right? I would say that's quite clear, but indeed we'll need to mention it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's true, we don't mention that somewhere, we should mention that as well.
Co-authored-by: Helena <hexylena@galaxians.org>
@hexylena is this ready to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks good, let's ship it.
FOR CONTRIBUTOR:
We added the gene.iobio tool to Galaxy based on creating URLs. Before we wanted to add clin.iobio, but it will not be supported in the long term and gene.iobio was the part of clin.iobio that we actually wanted to have. Related PRs: usegalaxy-eu/temporary-tools#26