Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapatac2 to 2.6.4 #6157

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

pavanvidem
Copy link
Member

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@bgruening
Copy link
Member

Output anndata_out: different than expected, difference (using sim_size):
( /tmp/tmpnl409ww9tl.macs3.pbmc_500_chr21.h5ad v. /tmp/tmp298vgu87tl.macs3.pbmc_500_chr21.h5ad )
Files /tmp/tmpnl409ww9tl.macs3.pbmc_500_chr21.h5ad=2667292b but /tmp/tmp298vgu87tl.macs3.pbmc_500_chr21.h5ad=1979950b - compare by size (delta=20000) failed

@pavanvidem
Copy link
Member Author

yes, that's strange! There are different number of peaks compared to the previous version and both use the same version of macs3. Maybe some dependency or some hidden parameter is causing this. I'm investigating it.

@pavanvidem
Copy link
Member Author

a new param was added which had hard coded value in the previous version. Now the tests should generate the same results as the previous version.

@bgruening bgruening merged commit b37248e into galaxyproject:main Jul 17, 2024
14 checks passed
@pavanvidem
Copy link
Member Author

Thanks @bgruening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants