Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatelessTags component memory leaks in edit mode #17250

Closed
itisAliRH opened this issue Jan 8, 2024 · 2 comments
Closed

StatelessTags component memory leaks in edit mode #17250

itisAliRH opened this issue Jan 8, 2024 · 2 comments
Assignees
Milestone

Comments

@itisAliRH
Copy link
Member

itisAliRH commented Jan 8, 2024

Describe the bug
client/src/components/TagsMultiselect/StatelessTags.vue has significant performance issues in edit mode (not disabled) when rendered more than a few times on a page.

ref: #16607 and #17219

Galaxy Version and/or server at which you observed the bug
Commit: 4e33216

To Reproduce
Steps to reproduce the behavior:

  1. Go to /datasets/list with a large number of items (or any other pages using StatelessTags)
  2. Try scrolling or add/delete tags
@guerler guerler added this to the 23.2 milestone Jan 8, 2024
@guerler guerler moved this to Triage/Discuss in UI/UX Working Group - weeklies Jan 8, 2024
@ElectronicBlueberry ElectronicBlueberry self-assigned this Jan 9, 2024
@guerler guerler moved this from Triage/Discuss to To Do, Assigned in UI/UX Working Group - weeklies Jan 9, 2024
@jdavcs jdavcs modified the milestones: 23.2, 24.0 Jan 10, 2024
@ElectronicBlueberry
Copy link
Member

Update on the memory leak:

  • the leak only occurs when the VueMultiselect component is rendered
  • the leak only occurs if all items in the list have no tags. As soon as one item has at least one tag, it stabilizes, which explains while I could not reproduce it before

@itisAliRH
Copy link
Member Author

#17331 fixed this issue!

@martenson martenson moved this from To Do, Assigned to Done in UI/UX Working Group - weeklies Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants