Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering versions of tool by date instead of version #15071

Closed
anilthanki opened this issue Nov 28, 2022 · 3 comments
Closed

Ordering versions of tool by date instead of version #15071

anilthanki opened this issue Nov 28, 2022 · 3 comments

Comments

@anilthanki
Copy link
Contributor

Describe the bug
At the moment, Galaxy with more than one version of tools list them out sorting naturally based on version number. But, we have case when someone introduced extra characters in tool version (i.e. +1, +2, +3) sending the latest version of the tool to the bottom of the list. Also with this Galaxy choses other than the latest version of the tool by default.

To Reproduce
install more than one version of scanpy tool from ebi-gxa and try and look at different versions.

Expected behavior
Tool should be listed by their push date instead of version, for having latest changes in the top.

Screenshots
image

@mvdbeek
Copy link
Member

mvdbeek commented Nov 28, 2022

Sorry, I don't think we can change this, versions need to follow a sortable scheme. We're using pep440 as implemented via packaging.version:

>>> import packaging.version
>>> packaging.version.parse('1.7.2+galaxy0') > packaging.version.parse('1.8.1+1+galaxy0')
True

@mvdbeek mvdbeek closed this as completed Nov 28, 2022
@pcm32
Copy link
Member

pcm32 commented Nov 29, 2022

@anilthanki I think that we can fix this in the meantime by changing the version scheme used for those tools and pushing a newer version to the toolshed.

Would it be feasible to check for packaging.version compliance on planemo at lint time perhaps @mvdbeek? The problem I think is that 1.8.1+1+galaxy0 seems to be acceptable to packaging.version (the above snippet is not failing with a parsing exception). I don't see on the planemo code any explicit checks done with packaging.version. To avoid these sort of issues in the future I mean.

@martenson
Copy link
Member

@pcm32 Both of these are compliant versions according to the scheme and Planemo does not necessarily have the info about what the version should be bigger than. Possibly this could be toolshed-enforced I guess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants