Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip ed should be excluded from benchmarks #919

Open
mrq1911 opened this issue Oct 3, 2024 · 1 comment
Open

skip ed should be excluded from benchmarks #919

mrq1911 opened this issue Oct 3, 2024 · 1 comment

Comments

@mrq1911
Copy link
Member

mrq1911 commented Oct 3, 2024

          skip ed should be excluded, cc @dmoka

Originally posted by @mrq1911 in #889 (comment)

@dmoka
Copy link
Contributor

dmoka commented Nov 4, 2024

I think it is fine, as in every on_transfer we start with checking if the ED should be skipped.

impl OnTransfer<AccountId, AssetId, Balance> for SufficiencyCheck {
fn on_transfer(asset: AssetId, from: &AccountId, to: &AccountId, _amount: Balance) -> DispatchResult {
if pallet_route_executor::Pallet::<Runtime>::skip_ed_lock() {
return Ok(());
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants