-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsdoc/require-jsdoc - publicOnly not working with contexts[].PropertyDefinition #1122
Comments
…ublic `accessibility`; fixes gajus#1122
🎉 This issue has been resolved in version 46.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@brettz9 same thing with Should I open a separate issue? |
Also, thanks for jumping on that so quickly! |
I need a code sample regardless of where you post it. |
It's the exact same issue but for class methods instead of properties |
So your context is exactly |
Moved to #1124 😄 |
tl;dr: Trying to configure a rule so that we document all public members/properties/accessors.
Expected behavior
When using
jsdoc/require-jsdoc
I would expectpublicOnly
andcontexts[].PropertyDefinition
together to mean that public properties required docs.Actual behavior
Private/protected members are also failing the lint check too (unexpectedly).
We tried
ClassProperty
too, but that appears to cause a lot of false negatives.For context there are also these related tickets, but we did not find the answer:
ESLint Config
ESLint sample
Environment
eslint-plugin-jsdoc
version: 46.4.0The text was updated successfully, but these errors were encountered: