fix: ignore arrow functions with predicates in arrow-parens (#418)

gajus · Jul 18, 2019 · 7560260 · 7560260
1 parent 94a9e8b
commit 7560260
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/rules/arrowParens.js b/src/rules/arrowParens.js
@@ -50,6 +50,12 @@ export default {
         return;
       }
 
+      // Similarly, a predicate always requires parens just like a return type
+      // does, and therefore this case can also be safely ignored.
+      if (node.predicate) {
+        return;
+      }
+
       // "as-needed", { "requireForBlockBody": true }: x => x
       if (
         requireForBlockBody &&

diff --git a/tests/rules/assertions/arrowParens.js b/tests/rules/assertions/arrowParens.js
@@ -331,6 +331,8 @@ export default {
     {code: '<T>(a: T) => { return a; }',
       options: ['always', {requireForBlockBody: true}]},
     {code: '<T>(a: T) => { return a; }',
+      options: ['as-needed', {requireForBlockBody: true}]},
+    {code: '(a): %checks => typeof a === "number"',
       options: ['as-needed', {requireForBlockBody: true}]}
 
   ]