Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SetDisableScreenBlanking(bool) for desktop #4567

Closed
2 tasks done
andydotxyz opened this issue Jan 26, 2024 · 4 comments
Closed
2 tasks done

Implement SetDisableScreenBlanking(bool) for desktop #4567

andydotxyz opened this issue Jan 26, 2024 · 4 comments
Labels
blocker Items that would block a forthcoming release

Comments

@andydotxyz
Copy link
Member

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

SetDisableScreenBlanking(bool) was added mobile only for first pass

Is it possible to construct a solution with the existing API?

No response

Describe the solution you'd like to see.

support all platforms

@dweymouth
Copy link
Contributor

This might actually be a more complex API on desktop. It seems on MacOS at least, you can either disable the display from shutting off entirely (which would be desired in eg a movie player), or disable the system from sleeping but allowing the display to turn off (which would be useful for eg. a music player). Perhaps SetDisableScreenBlanking should be moved to the mobile driver to allow a more complex three-state API for desktop, if it is possible for other OSes as well.

https://developer.apple.com/library/archive/qa/qa1340/_index.html

@andydotxyz
Copy link
Member Author

That is a good point. But conceptually isn't the screen going off and the system sleeping separate concerns? I.e. disabling the screen off is universal but disabling suspend/sleep is desktop specific?

@dweymouth
Copy link
Contributor

Also a good point. Hopefully it is possible to control the 2 independently on all desktop platforms. Looks like on Mac it probably is

@andydotxyz
Copy link
Member Author

This was resolved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release
Projects
None yet
Development

No branches or pull requests

2 participants