From f7646155b320a46f462ea1595ab00ef6674bacfa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jacob=20Alz=C3=A9n?= Date: Thu, 11 Nov 2021 13:34:01 +0100 Subject: [PATCH 1/7] Update PR template with binary size check --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 29644ffb25..eb6008f7ef 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -21,3 +21,4 @@ Fixes #(issue) - [ ] Public APIs match existing style. - [ ] Any breaking changes have a deprecation path or have been discussed. - [ ] Updated the vendor folder (using `go mod vendor`). +- [ ] Check for binary size increases while importing new modules. From 6b33dbc83efe19fc2314aa164d5ae6b79bd42bd1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jacob=20Alz=C3=A9n?= Date: Thu, 11 Nov 2021 13:35:40 +0100 Subject: [PATCH 2/7] Force issues to use the templates --- .github/ISSUE_TEMPLATE/config.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index d46e1c6e39..0a0f84803c 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -2,3 +2,5 @@ contact_links: - name: Ask a question url: https://fyne.io/support/ about: For a toolkit question or help with your code go to our support page + +blank_issues_enabled: false From 59a539983bd1115cf8537a894a386b1b38b29a36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jacob=20Alz=C3=A9n?= Date: Thu, 11 Nov 2021 13:38:18 +0100 Subject: [PATCH 3/7] Better wording for sizes --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index eb6008f7ef..cffd345514 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -21,4 +21,4 @@ Fixes #(issue) - [ ] Public APIs match existing style. - [ ] Any breaking changes have a deprecation path or have been discussed. - [ ] Updated the vendor folder (using `go mod vendor`). -- [ ] Check for binary size increases while importing new modules. +- [ ] Check for binary size increases when importing new modules. From 5300e2cf0b50d509306e4c2ab9dcc32145b7a923 Mon Sep 17 00:00:00 2001 From: Andy Williams Date: Mon, 6 Dec 2021 14:33:37 -0800 Subject: [PATCH 4/7] Added date to changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e61c931e8..b369e636b7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ This file lists the main changes with each version of the Fyne toolkit. More detailed release notes can be found on the [releases page](https://github.com/fyne-io/fyne/releases). -## 2.1.2 - Ongoing +## 2.1.2 - 6 December 2021 ### Fixed From 6c35798dfe076cd244b66f3f44736e0d68f733c8 Mon Sep 17 00:00:00 2001 From: RockSteady <34389545+RocksteadyTC@users.noreply.github.com> Date: Thu, 9 Dec 2021 17:51:23 -0600 Subject: [PATCH 5/7] Fixing links Some links needed fixing to work: - Vision - Roadmap - Slack - Issue list - Contributing Code --- CONTRIBUTING.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ba3f18035e..3e455e097a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,7 @@ There are various ways to contribute, perhaps the following helps you know how t If you've found something wrong we want to know about it, please help us understand the problem so we can resolve it. -1. Check to see if this already is recorded, if so add some more information [issue list](/fyne-io/fyne/issues) +1. Check to see if this already is recorded, if so add some more information [issue list](https://github.com/fyne-io/fyne/issues) 2. If not then create a new issue using the [bug report template](https://github.com/fyne-io/fyne/issues/new?assignees=&labels=&template=bug_report.md&title=) 3. Stay involved in the conversation on the issue as it is triaged and progressed. @@ -27,12 +27,12 @@ If you can follow these steps then your code should get accepted fast. ## Adding a feature It's always good news to hear that people want to contribute functionality. -But first of all check that it fits within our [[Vision]] and if we are already considering it on our [[Roadmap]]. -If you're not sure then you should join our #fyne-contributors channel on the gophers Slack server +But first of all check that it fits within our [Vision](https://github.com/fyne-io/fyne/wiki/Vision) and if we are already considering it on our [Roadmap](https://github.com/fyne-io/fyne/wiki/Roadmap). +If you're not sure then you should join our #fyne-contributors channel on the [Gophers Slack server](https://gophers.slack.com/app_redirect?channel=fyne-contributors). Once you are ready to code then the following steps should give you a smooth process: -1. Read through the "Contributing Code" section further down this page. +1. Read through the [Contributing Code](#contributing-code) section further down this page. 2. Think about how you would structure your code and how it can be tested. 3. Write some code and enjoy the ease of writing Go code for even a complex project :). 4. Run the tests and make sure everything still works as expected using `go test ./...`. From 8d84be5fe6747bd61d38f04796e971c0ffd1449e Mon Sep 17 00:00:00 2001 From: Andy Williams Date: Tue, 21 Dec 2021 17:46:30 -0800 Subject: [PATCH 6/7] Attempt to fix ccoverage parallel bug --- .github/workflows/platform_tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/platform_tests.yml b/.github/workflows/platform_tests.yml index a25fb1cf75..e5a236bc5b 100644 --- a/.github/workflows/platform_tests.yml +++ b/.github/workflows/platform_tests.yml @@ -7,7 +7,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [1.14.x, 1.17.x] + go-version: [1.14, 1.17] os: [ubuntu-latest, windows-latest, macos-latest] steps: @@ -38,4 +38,4 @@ jobs: GOROOT: ${{steps.setup-go-faster.outputs.GOROOT}} with: path-to-profile: coverage.out - if: ${{ runner.os == 'Linux' && github.event_name == 'push' }} + if: ${{ runner.os == 'Linux' && matrix.go-version == '1.17' && github.event_name == 'push' }} From 7595a4bdbddb53d1185ea687d1d3df8551ee3e97 Mon Sep 17 00:00:00 2001 From: cui fliter Date: Tue, 15 Mar 2022 18:33:59 +0800 Subject: [PATCH 7/7] fix some typos (#2845) Signed-off-by: cuishuang --- CHANGELOG.md | 2 +- cmd/fyne/commands/command.go | 2 +- cmd/fyne/internal/mobile/binres/binres_test.go | 2 +- internal/driver/mobile/file_ios.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b369e636b7..b938b38eca 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -216,7 +216,7 @@ More detailed release notes can be found on the [releases page](https://github.c * Correct initial state of entry validation * fix entry widget mouse drag selection when scrolled * List widget panic when refreshing after changing content length (#1864) -* Fix image caching that was too agressive on resize +* Fix image caching that was too aggressive on resize * Pointer and cursor misalignment in widget.Entry (#1937) * SIGSEGV Sometimes When Closing a Program by Clicking a Button (#1604) * Advanced Color Picker shows Black for custom primary color as RGBA (#1970) diff --git a/cmd/fyne/commands/command.go b/cmd/fyne/commands/command.go index 4c35c94422..dc08fd0926 100644 --- a/cmd/fyne/commands/command.go +++ b/cmd/fyne/commands/command.go @@ -6,7 +6,7 @@ import "fyne.io/fyne/v2/cmd/fyne/internal/commands" // Command defines the required functionality to provide a subcommand to the "fyne" tool. // // Deprecated: Access to the internal cli commands are being removed. -// Better versions of bundler, installer, packager and releaser will be avaliable in the future. +// Better versions of bundler, installer, packager and releaser will be available in the future. type Command interface { AddFlags() PrintHelp(string) diff --git a/cmd/fyne/internal/mobile/binres/binres_test.go b/cmd/fyne/internal/mobile/binres/binres_test.go index feab9ed73c..2dbcc19c31 100644 --- a/cmd/fyne/internal/mobile/binres/binres_test.go +++ b/cmd/fyne/internal/mobile/binres/binres_test.go @@ -329,7 +329,7 @@ func compareStrings(t *testing.T, a, b []string) error { } if err == nil && v == "__" { if !strings.HasPrefix(x, "4.0.") { - // as of the time of this writing, the current version of build tools being targetted + // as of the time of this writing, the current version of build tools being targeted // reports 4.0.4-1406430. Previously, this was 4.0.3. This number is likely still due // to change so only report error if 4.x incremented. // diff --git a/internal/driver/mobile/file_ios.go b/internal/driver/mobile/file_ios.go index 1245f57a14..f176c39a56 100644 --- a/internal/driver/mobile/file_ios.go +++ b/internal/driver/mobile/file_ios.go @@ -95,7 +95,7 @@ func (s *secureWriteCloser) Close() error { func existsURI(u fyne.URI) (bool, error) { if u.Scheme() != "file" { - return true, errors.New("cannot check existance of " + u.Scheme() + " on iOS") + return true, errors.New("cannot check existence of " + u.Scheme() + " on iOS") } cStr := C.CString(u.Path())