Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP API should leverage HTTP Cache (via Etag or Last-Modified-Since headers) #494

Open
azasypkin opened this issue May 23, 2016 · 4 comments

Comments

@azasypkin
Copy link
Member

Ideally every "get-like/read" response should include proper http cache headers. It will help client app to consume less traffic (at least in its current state when polling is heavily used) and reduce server load (maybe we don't expect too many requests though).

The only thing I'm not sure of is if it's possible to do a proper caching of POST responses at all :/

cc @Yoric @fabricedesre

@Yoric
Copy link

Yoric commented May 23, 2016

This would definitely make sense for the lists of services and channels.

Not so much for interaction with adapters, of course.

@azasypkin
Copy link
Member Author

Not so much for interaction with adapters, of course.

Mmm, what is reason that prevents us from leveraging HTTP Cache for channels/get as well?

@Yoric
Copy link

Yoric commented May 24, 2016

I guess we could ask Adapters to provide an Etag if they want to support caching fetch operations.

@azasypkin
Copy link
Member Author

Yep, that would probably work, but will basically tie adapters to HTTP and introduce more complexity inside adapter :/

Can't REST layer somehow determine (before or after serialization) that response it's going to return hasn't changed? It will also cover http requests that consist of multiple "adapter fetch requests" that we use currently (and it's pretty awesome feature btw!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants