Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of optional named operator when all values are null #10

Closed
Paul-Martin opened this issue Mar 14, 2013 · 1 comment
Closed

Comments

@Paul-Martin
Copy link

UriTemplate.parse('/foo{?a,b,c}').expand({});
produces
"/foo?c="
should be
"/foo"

same for operators '&' and ';'

It seems to me that 'if (isFirstVarspec)' block starting at line 668 is unnecessary and removing it will resolve this issue without unwanted side effects.
.

@fxa
Copy link
Owner

fxa commented Mar 14, 2013

Of course, you are right.
But I had some side effects, when removing this block.
I will add your test case and fix the bug

@fxa fxa closed this as completed in 819db32 Mar 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants