From bc31162cc2207a3f565f381458f63b64ea78f1d2 Mon Sep 17 00:00:00 2001 From: Jes Cok Date: Thu, 21 Mar 2024 22:09:26 +0800 Subject: [PATCH] all: call Close() after reading http.Response.Body As the doc of http.Response.Body says: // The http Client and Transport guarantee that Body is always // non-nil, even on responses without a body or responses with // a zero-length body. It is the caller's responsibility to // close Body. Signed-off-by: Jes Cok --- contrib/lock/client/client.go | 1 + server/etcdserver/api/etcdhttp/peer_test.go | 1 + 2 files changed, 2 insertions(+) diff --git a/contrib/lock/client/client.go b/contrib/lock/client/client.go index 066b70e51d2..ddb5498e55b 100644 --- a/contrib/lock/client/client.go +++ b/contrib/lock/client/client.go @@ -69,6 +69,7 @@ func write(key string, value string, version int64) error { if err != nil { log.Fatalf("failed to read request body: %s", err) } + httpResp.Body.Close() resp := new(response) err = json.Unmarshal(respBytes, resp) diff --git a/server/etcdserver/api/etcdhttp/peer_test.go b/server/etcdserver/api/etcdhttp/peer_test.go index 9ed02f43962..0ce670f764e 100644 --- a/server/etcdserver/api/etcdhttp/peer_test.go +++ b/server/etcdserver/api/etcdhttp/peer_test.go @@ -103,6 +103,7 @@ func TestNewPeerHandlerOnRaftPrefix(t *testing.T) { if err != nil { t.Fatalf("unexpected io.ReadAll error: %v", err) } + resp.Body.Close() if w := "test data"; string(body) != w { t.Errorf("#%d: body = %s, want %s", i, body, w) }