Merge pull request etcd-io#17634 from callthingsoff/httpresponse_clos…

…e_after_read all: call Close() after reading http.Response.Body
fuweid · Mar 25, 2024 · e4448c4 · e4448c4
2 parents 7f9011a + bc31162
commit e4448c4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/contrib/lock/client/client.go b/contrib/lock/client/client.go
@@ -69,6 +69,7 @@ func write(key string, value string, version int64) error {
 	if err != nil {
 		log.Fatalf("failed to read request body: %s", err)
 	}
+	httpResp.Body.Close()
 
 	resp := new(response)
 	err = json.Unmarshal(respBytes, resp)

diff --git a/server/etcdserver/api/etcdhttp/peer_test.go b/server/etcdserver/api/etcdhttp/peer_test.go
@@ -103,6 +103,7 @@ func TestNewPeerHandlerOnRaftPrefix(t *testing.T) {
 		if err != nil {
 			t.Fatalf("unexpected io.ReadAll error: %v", err)
 		}
+		resp.Body.Close()
 		if w := "test data"; string(body) != w {
 			t.Errorf("#%d: body = %s, want %s", i, body, w)
 		}