Update Marketplace Precompile ABI #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm... Thanks for updating the interface... looks great |
KarishmaBothara
approved these changes
Sep 30, 2024
Nick95550
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Update marketplace precompile ABI and duration + marketplace_id input params * Fix bug in marketplace that allows for 0 duration * fmt * Update xrpl-bridge deps * fmt.. * Update types in abi + update index.ts abi * prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few small inconsistencies picked up when testing the marketplace precompile.
This also fixes a minor bug in the marketplace pallet that allowed listings to be created with Some(0) duration, this would result in the listing never being cleared automatically