diff --git a/pallet/doughnut/src/lib.rs b/pallet/doughnut/src/lib.rs index 45cefae5f..fa23d3c79 100644 --- a/pallet/doughnut/src/lib.rs +++ b/pallet/doughnut/src/lib.rs @@ -458,10 +458,10 @@ pub mod pallet { ); // permission domain - topping validations - let Some(topping_payload) = doughnut_v1.get_topping(TRN_PERMISSION_DOMAIN) else { + let Some(mut topping_payload) = doughnut_v1.get_topping(TRN_PERMISSION_DOMAIN) else { return Err(Error::::TRNDomainNotfound)? }; - let topping = Topping::decode(&mut topping_payload.clone()) + let topping = Topping::decode(&mut topping_payload) .map_err(|_| Error::::ToppingDecodeFailed)?; // check topping permissions diff --git a/pallet/ethy/src/ethereum_http_cli.rs b/pallet/ethy/src/ethereum_http_cli.rs index 3153dec95..a49d94b28 100644 --- a/pallet/ethy/src/ethereum_http_cli.rs +++ b/pallet/ethy/src/ethereum_http_cli.rs @@ -18,7 +18,7 @@ use sp_std::prelude::*; #[cfg(not(feature = "std"))] use sp_std::alloc::string::ToString; -#[cfg(std)] +#[cfg(feature = "std")] use std::string::ToString; use seed_pallet_common::log; diff --git a/pallet/futurepass/Cargo.toml b/pallet/futurepass/Cargo.toml index e9222b1ae..8ec4bcdce 100644 --- a/pallet/futurepass/Cargo.toml +++ b/pallet/futurepass/Cargo.toml @@ -12,7 +12,7 @@ targets = ["x86_64-unknown-linux-gnu"] [dependencies] hex = { workspace = true } -hex-literal = { workspace = true, optional = true } +hex-literal = { workspace = true } codec = { workspace = true } log = { workspace = true } scale-info = { workspace = true } @@ -66,4 +66,4 @@ std = [ "precompile-utils/std", ] try-runtime = ["frame-support/try-runtime"] -runtime-benchmarks = ["frame-benchmarking", "hex-literal", "seed-runtime/runtime-benchmarks"] +runtime-benchmarks = ["frame-benchmarking", "seed-runtime/runtime-benchmarks"] diff --git a/pallet/nft/src/lib.rs b/pallet/nft/src/lib.rs index ef8b11b68..7f79e1c13 100644 --- a/pallet/nft/src/lib.rs +++ b/pallet/nft/src/lib.rs @@ -59,7 +59,6 @@ mod impls; pub mod traits; mod types; -pub use impls::*; pub use pallet::*; pub use types::*; diff --git a/pallet/sft/src/lib.rs b/pallet/sft/src/lib.rs index 31eea7b56..5137e87c8 100644 --- a/pallet/sft/src/lib.rs +++ b/pallet/sft/src/lib.rs @@ -40,7 +40,6 @@ mod weights; pub use weights::WeightInfo; -pub use impls::*; pub use pallet::*; pub use types::*; diff --git a/pallet/token-approvals/src/tests.rs b/pallet/token-approvals/src/tests.rs index c2fc3b6ac..25eb53ba3 100644 --- a/pallet/token-approvals/src/tests.rs +++ b/pallet/token-approvals/src/tests.rs @@ -22,6 +22,7 @@ pub fn create_account(seed: u64) -> AccountId { AccountId::from(H160::from_low_u64_be(seed)) } +#[allow(dead_code)] pub struct TestData { pub coll_owner: AccountId, pub coll_id: CollectionUuid, diff --git a/pallet/tx-fee-pot/src/lib.rs b/pallet/tx-fee-pot/src/lib.rs index b25e02670..51aa33b61 100644 --- a/pallet/tx-fee-pot/src/lib.rs +++ b/pallet/tx-fee-pot/src/lib.rs @@ -125,7 +125,7 @@ impl OnUnbalanced> for Pallet { // this amount was burnt from caller when tx fees were paid (incl. tip), move the funds into // the pot let note_amount = amount.peek(); - T::FeeCurrency::deposit_creating(&Self::account_id(), note_amount); + let _ = T::FeeCurrency::deposit_creating(&Self::account_id(), note_amount); Self::accrue_era_tx_fees(note_amount); } @@ -160,7 +160,7 @@ impl OnUnbalanced> for Pallet { let note_amount = amount.peek(); // mint `note_amount` (offsets `amount` imbalance) - T::StakeCurrency::deposit_creating(&Self::account_id(), note_amount); + let _ = T::StakeCurrency::deposit_creating(&Self::account_id(), note_amount); } } diff --git a/pallet/xrpl/src/types.rs b/pallet/xrpl/src/types.rs index 72bc78ed8..f1fbbc87e 100644 --- a/pallet/xrpl/src/types.rs +++ b/pallet/xrpl/src/types.rs @@ -240,7 +240,7 @@ impl TryFrom<&[u8]> for XRPLTransaction { type Error = &'static str; fn try_from(value: &[u8]) -> Result { - let deserializer = &mut Deserializer::new(value.clone().to_vec(), field_info_lookup()); + let deserializer = &mut Deserializer::new(value.to_vec(), field_info_lookup()); let tx_json = deserializer .to_json(&TypeCode::Object, &value) .map_err(|_e| "failed to convert encoded_msg to json value")?;