Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: CronController can avoid back-scheduling for Forbid #51

Open
irvinlim opened this issue Apr 15, 2022 · 0 comments
Open

Enhancement: CronController can avoid back-scheduling for Forbid #51

irvinlim opened this issue Apr 15, 2022 · 0 comments
Labels
area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/enhancement Categorizes issues or PRs related to enhancements, rather than full features.

Comments

@irvinlim
Copy link
Member

Since we have updated to use the JobQueueController instead, the process of admitting a Job to be started is now asynchronous. The CronController will back-schedule multiple Jobs even though it should know at this point to just ignore the back-scheduling for ConcurrencyPolicyForbid, because the JobQueueController will just reject them as AdmissionError:

NAME                          AGE   PHASE            CREATED TASKS   RUN TIME   FINISH TIME
jobconfig-sample.1650055799   7s    Succeeded        1                          3s
jobconfig-sample.1650055814   7s    AdmissionError   0                          7s
jobconfig-sample.1650055829   7s    AdmissionError   0                          7s
jobconfig-sample.1650055844   7s    AdmissionError   0                          7s
jobconfig-sample.1650055859   7s    AdmissionError   0                          7s

In case users set a high back-scheduling limit, this may result in huge bursts of unnecessary Job creation.

@irvinlim irvinlim added component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) kind/enhancement Categorizes issues or PRs related to enhancements, rather than full features. labels Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/enhancement Categorizes issues or PRs related to enhancements, rather than full features.
Projects
None yet
Development

No branches or pull requests

1 participant