Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate OptionSpec that is required without default value if scheduled #10

Open
irvinlim opened this issue Mar 25, 2022 · 0 comments
Open

Validate OptionSpec that is required without default value if scheduled #10

irvinlim opened this issue Mar 25, 2022 · 0 comments
Labels
area/api Related to public APIs, including CRD design, configuration, etc component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature.

Comments

@irvinlim
Copy link
Member

We can and should reject any JobConfigs from being saved if there is a required option but there is no default value set, and will fail when run automatically on schedule.
@irvinlim irvinlim added area/api Related to public APIs, including CRD design, configuration, etc good first issue Good for newcomers component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) labels Mar 25, 2022
@irvinlim irvinlim added kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature. and removed good first issue Good for newcomers labels Apr 11, 2022
@irvinlim irvinlim added the good first issue Good for newcomers label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api Related to public APIs, including CRD design, configuration, etc component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@irvinlim