-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: all resources have name type param #357
Conversation
export function workflow<Input = any, Output = any>( | ||
): Workflow<Name, Input, Output>; | ||
export function workflow< | ||
Name extends string = string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need it on workflow? Does it have a representation on the cdk side? Maybe monitoring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be consistent. A workflow may be addressable if it supported overrides to the destination of task, injection of env variables, permission to invoke it, or analytics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same argument for transactions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the changes to the way we extract the types on the cdk side? Is it still using the export name instead of the string literal? We have code to check if the export name is the same as the string name and favor it to maintain the ide connection when it's the same.
They were all using the types with logic to check for "same as export name" and "different from export name". When the These all work the same as commands, tasks, and subscriptions. For: Before change: After change: |
No description provided.