fix: clean up create-eventual and use command in template instead of api.get/put/post #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-goodwin
changed the title
sam-goodwin
commented
Feb 27, 2023
Comment on lines
76
to
79
| new CfnOutput(stack, "${projectName}-api-endpoint", { | ||
| exportName: "${projectName}-api-endpoint", | ||
| value: service.gateway.url!, | ||
| }); |
There was a problem hiding this comment.
Can I get rid of this.
added 2 commits
February 27, 2023 17:10
thantos
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #297
Closes #298
Closes #299