feat: add middleware for APIs and Commands #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-goodwin
commented
Feb 13, 2023
thantos
reviewed
Feb 13, 2023
This change would remove that. Think it's a problem? |
Don't think so |
thantos
approved these changes
Feb 13, 2023
Reverted this and went the opposite direction. We require Node 18/web worker standard. As discussed, this aligns with Node 18 lambda, deno, cloudflare, bun. Can be polyfilled in edge cases. |
sam-goodwin
commented
Feb 14, 2023
| } else { | ||
| headers = (response.headers as Record<string, string>) ?? {}; | ||
| } | ||
| response.headers.forEach((value, key) => (headers[key] = value)); |
There was a problem hiding this comment.
always using the Fetch Headers object to avoid worrying about providing sane logic around header names
thantos
reviewed
Feb 14, 2023
| @@ -43,7 +43,6 @@ const ssm = new SSMClient({}); | |||
| // execute extensions logic | |||
|
|
|||
| while (true) { | |||
| console.log("next"); | |||
thantos
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.