Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: css 속성 변경 #70

Merged
merged 2 commits into from
Oct 16, 2023
Merged

refactor: css 속성 변경 #70

merged 2 commits into from
Oct 16, 2023

Conversation

hae-on
Copy link
Collaborator

@hae-on hae-on commented Oct 15, 2023

Issue

✨ 구현한 기능

css={css}가 적용 안되는 것을 바꿨습니다.

📢 논의하고 싶은 내용

별개이긴한데 Text 컴포넌트 문서에 보면 element랑 as랑 내용이 비슷한데 둘 중에 뭐가 찐...?인가요?

🎸 기타

x

@Leejin-Yang
Copy link
Collaborator

별개이긴한데 Text 컴포넌트 문서에 보면 element랑 as랑 내용이 비슷한데 둘 중에 뭐가 찐...?인가요?

앗..element 삭제 부탁드립니다 😅

@hae-on
Copy link
Collaborator Author

hae-on commented Oct 15, 2023

@Leejin-Yang

리드미에서만 지우면 되나요??
Text 컴포넌트 props 값에는 element인데 이건 그대로 두고?????????

@Leejin-Yang
Copy link
Collaborator

@hae-on

as prop을 넣어주는 것으로 동작해서, element props는 다 지워도 됩니다.!
감사합니다 해온 🙇‍♂️

Copy link
Member

@xodms0309 xodms0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿굿!

Copy link
Collaborator

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어프루브~~~~

@hae-on hae-on merged commit 96cd4fa into main Oct 16, 2023
1 check passed
@hae-on hae-on deleted the feat/issue-69 branch October 16, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css 속성 추가
3 participants