From 790dee2602010507dce6a3884444dcef86a1ebe1 Mon Sep 17 00:00:00 2001
From: frcroth <frcroth@gmail.com>
Date: Wed, 9 Aug 2023 18:15:27 +0200
Subject: [PATCH 1/5] Add abbreviation explanations on mobile

---
 myhpi/core/markdown/utils.py |  8 ++++----
 myhpi/static/js/myHPI.js     |  5 +++++
 myhpi/static/scss/myHPI.scss | 20 +++++++++++++++++++-
 3 files changed, 28 insertions(+), 5 deletions(-)

diff --git a/myhpi/core/markdown/utils.py b/myhpi/core/markdown/utils.py
index dd3e55a4..b095e51e 100644
--- a/myhpi/core/markdown/utils.py
+++ b/myhpi/core/markdown/utils.py
@@ -12,12 +12,12 @@ def render_markdown(text, context=None, with_abbreveations=True):
     """
     if context is None or not isinstance(context, dict):
         context = {}
-    markdown_html, toc = _transform_markdown_into_html(text, with_abbreveations=with_abbreveations)
+    markdown_html, toc = _transform_markdown_into_html(text, with_abbreviations=with_abbreveations)
     sanitised_markdown_html = _sanitise_markdown_html(markdown_html)
     return mark_safe(sanitised_markdown_html), mark_safe(toc)
 
 
-def _transform_markdown_into_html(text, with_abbreveations):
+def _transform_markdown_into_html(text, with_abbreviations):
     from myhpi.core.models import AbbreviationExplanation
 
     markdown_kwargs = _get_markdown_kwargs()
@@ -25,7 +25,7 @@ def _transform_markdown_into_html(text, with_abbreveations):
         MinuteExtension()
     )  # should be in settings.py, but module lookup doesn't work
     md = markdown.Markdown(**markdown_kwargs)
-    abbreveations = "\n\n" + (
+    abbreviations = "\n\n" + (
         "\n".join(
             [
                 f"*[{abbr.abbreviation}]: {abbr.explanation}"
@@ -33,5 +33,5 @@ def _transform_markdown_into_html(text, with_abbreveations):
             ]
         )
     )
-    text = smart_str(text) + abbreveations if with_abbreveations else smart_str(text)
+    text = smart_str(text) + abbreviations if with_abbreviations else smart_str(text)
     return md.convert(text), md.toc
diff --git a/myhpi/static/js/myHPI.js b/myhpi/static/js/myHPI.js
index 7198c8ca..ea00e445 100644
--- a/myhpi/static/js/myHPI.js
+++ b/myhpi/static/js/myHPI.js
@@ -109,3 +109,8 @@ window.onresize = () => {
     adaptNavbarToWindowSize()
     updateNavbarPosition()
 }
+
+/* https://stackoverflow.com/questions/12539006/tooltips-for-mobile-browsers */
+// To enable tooltips on mobile, add tabindex=0 to abbr elements.
+document.querySelectorAll("abbr")
+    .forEach(node => node.setAttribute("tabindex", "0"))
diff --git a/myhpi/static/scss/myHPI.scss b/myhpi/static/scss/myHPI.scss
index 1e4eccee..b5a8b466 100644
--- a/myhpi/static/scss/myHPI.scss
+++ b/myhpi/static/scss/myHPI.scss
@@ -286,4 +286,22 @@ h1.side-panel-title::after {
         margin-top: 50px;
         order: 3;
     }
-}
\ No newline at end of file
+}
+
+@media (pointer: coarse), (hover: none) {
+      [title] {
+        position: relative;
+        display: inline-flex;
+        justify-content: center;
+      }
+      [title]:focus::after {
+        content: attr(title);
+        position: absolute;
+        top: 90%;
+        color: #000;
+        background-color: #fff;
+        border: 1px solid;
+        width: fit-content;
+        padding: 3px;
+      }
+    }

From 37e3a27b0a05b0892406ef980e1923a0aaf672f2 Mon Sep 17 00:00:00 2001
From: abc013 <abc013@alpenjodel.de>
Date: Tue, 13 Feb 2024 21:02:31 +0100
Subject: [PATCH 2/5] Remove js-way and add filter for showing abbreviations on
 mobile apps

---
 myhpi/core/templates/core/information_page.html |  2 +-
 myhpi/core/templates/core/minutes.html          |  2 +-
 myhpi/core/templatetags/core_extras.py          | 14 ++++++++++++++
 myhpi/static/js/myHPI.js                        |  5 -----
 4 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/myhpi/core/templates/core/information_page.html b/myhpi/core/templates/core/information_page.html
index f2257080..17bb54db 100644
--- a/myhpi/core/templates/core/information_page.html
+++ b/myhpi/core/templates/core/information_page.html
@@ -12,7 +12,7 @@ <h1 class="page-title">
                 {{ page.title }}
             </span>
         </h1>
-        {{ parsed_md.0 }}
+        {{ parsed_md.0|touchify_abbrevations }}
     </div>
     <div class="col-lg-3">
         <div class="side-panel-container">
diff --git a/myhpi/core/templates/core/minutes.html b/myhpi/core/templates/core/minutes.html
index 3b4909a9..77a5f17c 100644
--- a/myhpi/core/templates/core/minutes.html
+++ b/myhpi/core/templates/core/minutes.html
@@ -11,7 +11,7 @@
             <h1>{{  page.title }}</h1>
         </div>
         <div class="col-9 minutes-text">
-            {{ parsed_md.0 }}
+            {{ parsed_md.0|touchify_abbrevations }}
         </div>
         <div class="col-3 minutes-meta">
             <aside class="side-panel border-accent">
diff --git a/myhpi/core/templatetags/core_extras.py b/myhpi/core/templatetags/core_extras.py
index 4b1724cc..a9348b00 100644
--- a/myhpi/core/templatetags/core_extras.py
+++ b/myhpi/core/templatetags/core_extras.py
@@ -49,6 +49,20 @@ def tag_external_links(content):
     return template.render(Context())
 
 
+@register.filter(name="touchify_abbrevations")
+def touchify_abbrevations(content):
+    """Takes the content of a website and inserts external link icons after every external link."""
+    external_links = re.finditer('<abbr[^>]*>[^<]*', content)
+    for link in reversed(list(external_links)):
+        content = (
+            content[: link.start() + 5]
+            + " tabindex=0"
+            + content[link.start() + 5 :]
+        )
+    template = Template("{% load bootstrap_icons %}" + content)
+    return template.render(Context())
+
+
 @register.filter(name="markdown")
 def markdown(value):
     return render_markdown(value)
diff --git a/myhpi/static/js/myHPI.js b/myhpi/static/js/myHPI.js
index ea00e445..7198c8ca 100644
--- a/myhpi/static/js/myHPI.js
+++ b/myhpi/static/js/myHPI.js
@@ -109,8 +109,3 @@ window.onresize = () => {
     adaptNavbarToWindowSize()
     updateNavbarPosition()
 }
-
-/* https://stackoverflow.com/questions/12539006/tooltips-for-mobile-browsers */
-// To enable tooltips on mobile, add tabindex=0 to abbr elements.
-document.querySelectorAll("abbr")
-    .forEach(node => node.setAttribute("tabindex", "0"))

From 5050e549453f1169f447b2c90da82a2522775597 Mon Sep 17 00:00:00 2001
From: frcroth <frcroth@gmail.com>
Date: Tue, 13 Feb 2024 22:18:51 +0100
Subject: [PATCH 3/5] Lint

---
 myhpi/core/templatetags/core_extras.py | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/myhpi/core/templatetags/core_extras.py b/myhpi/core/templatetags/core_extras.py
index b74fe259..83aeb4c9 100644
--- a/myhpi/core/templatetags/core_extras.py
+++ b/myhpi/core/templatetags/core_extras.py
@@ -56,13 +56,9 @@ def tag_external_links(content):
 @register.filter(name="touchify_abbrevations")
 def touchify_abbrevations(content):
     """Takes the content of a website and inserts external link icons after every external link."""
-    external_links = re.finditer('<abbr[^>]*>[^<]*', content)
+    external_links = re.finditer("<abbr[^>]*>[^<]*", content)
     for link in reversed(list(external_links)):
-        content = (
-            content[: link.start() + 5]
-            + " tabindex=0"
-            + content[link.start() + 5 :]
-        )
+        content = content[: link.start() + 5] + " tabindex=0" + content[link.start() + 5 :]
     template = Template("{% load bootstrap_icons %}" + content)
     return template.render(Context())
 

From 267f53d9d61a8e97d1c978a597a8c5a6cdf2eeb0 Mon Sep 17 00:00:00 2001
From: frcroth <frcroth@gmail.com>
Date: Tue, 13 Feb 2024 22:39:48 +0100
Subject: [PATCH 4/5] Rename stuff

---
 myhpi/core/templates/core/information_page.html |  2 +-
 myhpi/core/templates/core/minutes.html          |  2 +-
 myhpi/core/templatetags/core_extras.py          | 10 +++++-----
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/myhpi/core/templates/core/information_page.html b/myhpi/core/templates/core/information_page.html
index 2e120983..e875b121 100644
--- a/myhpi/core/templates/core/information_page.html
+++ b/myhpi/core/templates/core/information_page.html
@@ -12,7 +12,7 @@ <h1 class="page-title">
                 {{ page.title }}
             </span>
         </h1>
-        {{ parsed_md.0|touchify_abbrevations|tag_external_links }}
+        {{ parsed_md.0|touchify_abbreviations|tag_external_links }}
     </div>
     <div class="col-lg-3">
         <div class="side-panel-container">
diff --git a/myhpi/core/templates/core/minutes.html b/myhpi/core/templates/core/minutes.html
index 04ded6dc..6d6ddfd5 100644
--- a/myhpi/core/templates/core/minutes.html
+++ b/myhpi/core/templates/core/minutes.html
@@ -12,7 +12,7 @@
             <h1>{{  page.title }}</h1>
         </div>
         <div class="col-9 minutes-text">
-            {{ parsed_md.0|touchify_abbrevations|tag_external_links }}
+            {{ parsed_md.0|touchify_abbreviations|tag_external_links }}
         </div>
         <div class="col-3 minutes-meta">
             <aside class="side-panel border-accent">
diff --git a/myhpi/core/templatetags/core_extras.py b/myhpi/core/templatetags/core_extras.py
index 83aeb4c9..263c46df 100644
--- a/myhpi/core/templatetags/core_extras.py
+++ b/myhpi/core/templatetags/core_extras.py
@@ -53,11 +53,11 @@ def tag_external_links(content):
     return template.render(Context())
 
 
-@register.filter(name="touchify_abbrevations")
-def touchify_abbrevations(content):
-    """Takes the content of a website and inserts external link icons after every external link."""
-    external_links = re.finditer("<abbr[^>]*>[^<]*", content)
-    for link in reversed(list(external_links)):
+@register.filter(name="touchify_abbreviations")
+def touchify_abbreviations(content):
+    abbreviations = re.finditer("<abbr[^>]*>[^<]*", content)
+    print(list(abbreviations))
+    for link in reversed(list(abbreviations)):
         content = content[: link.start() + 5] + " tabindex=0" + content[link.start() + 5 :]
     template = Template("{% load bootstrap_icons %}" + content)
     return template.render(Context())

From 5f7d0f70bdc1b7bc13e4de2035525da8998ac064 Mon Sep 17 00:00:00 2001
From: frcroth <frcroth@gmail.com>
Date: Tue, 13 Feb 2024 22:40:32 +0100
Subject: [PATCH 5/5] Remove print

---
 myhpi/core/templatetags/core_extras.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/myhpi/core/templatetags/core_extras.py b/myhpi/core/templatetags/core_extras.py
index 263c46df..eed12bdd 100644
--- a/myhpi/core/templatetags/core_extras.py
+++ b/myhpi/core/templatetags/core_extras.py
@@ -56,7 +56,6 @@ def tag_external_links(content):
 @register.filter(name="touchify_abbreviations")
 def touchify_abbreviations(content):
     abbreviations = re.finditer("<abbr[^>]*>[^<]*", content)
-    print(list(abbreviations))
     for link in reversed(list(abbreviations)):
         content = content[: link.start() + 5] + " tabindex=0" + content[link.start() + 5 :]
     template = Template("{% load bootstrap_icons %}" + content)