Option not inferred for optional sproc parameters of type binary and nvarchar

[cmeeren]

Description

SqlClient does not infer the correct optionality for all stored procedure parameters.

For example, given this sproc with three optional parameters

CREATE PROCEDURE [dbo].[Procedure1]
  @param1 int = NULL,
  @param2 nvarchar(10) = NULL,
  @param3 binary(10) = NULL
AS
  SELECT 1

only the first one is inferred to be optional:

Note however that the type signature seems correct:

[smoothdeveloper]

@cmeeren this is tied to this:

FSharp.Data.SqlClient/src/SqlClient.DesignTime/SqlClientExtensions.fs

Line 310 in c8148eb

let valueTypeWithNullDefault = typeInfo.IsValueType && defaultValue = Some(null)

Only value type are option wrapped, which I think makes sense.

You may pass null to work around your issue.

[cmeeren]

I see, I didn't notice that. Then at least I can use my sprocs :)

IMHO a uniform option interface for all optional params would make more sense, to clearly indicate that they are, in fact, optional - and also because in F#, we're usually using option for these arguments anyway, so this would save having to use Option.toObj. Feel free to close this issue if you don't agree. :)