Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain glob patterns matching folders in the README.toml do not work #1071

Closed
brlin-tw opened this issue Sep 11, 2024 · 1 comment · Fixed by #1078
Closed

Certain glob patterns matching folders in the README.toml do not work #1071

brlin-tw opened this issue Sep 11, 2024 · 1 comment · Fixed by #1078
Labels
bug Something isn't working

Comments

@brlin-tw
Copy link

brlin-tw commented Sep 11, 2024

The following project filetree:

.
├── folder-1
│   └── README.md
├── LICENSES
│   └── WTFPL.txt
├── README.md
└── REUSE.toml

with the following REUSE.toml rules:

version = 1

[[annotations]]
path = [
    "README.md"
]
SPDX-FileCopyrightText = '2024 林博仁(Buo-ren Lin) <buo.ren.lin@gmail.com>'
SPDX-License-Identifier = 'WTFPL'

[[annotations]]
path = [
    "folder-*/README.md"
]
SPDX-FileCopyrightText = '2024 林博仁(Buo-ren Lin) <buo.ren.lin@gmail.com>'
SPDX-License-Identifier = 'WTFPL'

resulted in the following REUSE tool lint error:

# MISSING COPYRIGHT AND LICENSING INFORMATION

The following files have no copyright and licensing information:
* folder-1/README.md

Refer to https://gitlab.com/brlin/reuse-tool-not-able-to-match-folder-glob-problem for the problem reproducer.

Known workaround

Replace the single asterisk in the filename pattern to double asterisks works, somehow:

[[annotations]]
path = [
    "folder-**/README.md"
]
@brlin-tw brlin-tw changed the title Certain glob patterns matching folders in the README.toml does not work Certain glob patterns matching folders in the README.toml do not work Sep 11, 2024
@carmenbianca carmenbianca added the bug Something isn't working label Sep 16, 2024
@carmenbianca
Copy link
Member

Interesting bug, thank you @brlin-tw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants