Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.3 support #295

Closed
rajeshreeputra opened this issue Aug 24, 2023 · 3 comments
Closed

PHP 8.3 support #295

rajeshreeputra opened this issue Aug 24, 2023 · 3 comments
Labels
enhancement

Comments

@rajeshreeputra
Copy link
Contributor

Steps required to reproduce the problem

  1. Be on PHP 8.3
  2. composer require friendsoftwig/twigcs

Expected Result

  • It should be compatible with PHP 8.3

Actual Result

  • friendsoftwig/twigcs is locked to version 6.2.0 and an update of this package was not requested.
  • friendsoftwig/twigcs 6.2.0 requires php ~8.0.0 || ~8.1.0 || ~8.2.0 -> your php version (8.3.0-dev) does not satisfy that requirement.
@rajeshreeputra
Copy link
Contributor Author

I have created PR #296 to support PHP 8.3.
Tested Locally and looks good. Please review.

@rajeshreeputra rajeshreeputra mentioned this issue Aug 24, 2023
Merged
@Ciloe
Copy link
Collaborator

Ciloe commented Aug 24, 2023

Good for me. Thanks !

@OwlyCode
Copy link
Collaborator

Solved by #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@localheinz @OwlyCode @Ciloe @rajeshreeputra