Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title per view #41

Open
2 tasks
anuveyatsu opened this issue Oct 6, 2017 · 1 comment
Open
2 tasks

Title per view #41

anuveyatsu opened this issue Oct 6, 2017 · 1 comment
Assignees

Comments

@anuveyatsu
Copy link
Member

When generating specs for Plotly graphs, we need to have some default name for cases when there is no title property in a view. At the moment, we are using title property if exists and making it empty string if it does not.

const plotlySpec = {
    data
    , layout: {
      title: view.title ? view.title : ''
      , height: 450
      , xaxis: {
        title: view.spec.group
      }
    }
  }

Use in the following priority:

  1. view.title
  2. view.name
  3. A view for ${view.resources.join(', ')}

Acceptance criteria

  • plotly graphs always have titles

Tasks

  • refactor simpleToPlotly function in /lib/view.js
@anuveyatsu anuveyatsu added this to the Sprint - 23 Oct 2017 milestone Oct 6, 2017
@anuveyatsu anuveyatsu self-assigned this Oct 6, 2017
@rufuspollock
Copy link
Contributor

@anuveyatsu if using view.name i'd convert back into human style (e.g. - to space capitalise etc)

@zelima zelima modified the milestones: Sprint - 6 Nov 2017, Backlog Nov 6, 2017
@roll roll removed this from the Backlog milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants