Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"path" can be a string or arrray #27

Closed
dsantuc opened this issue Aug 10, 2017 · 5 comments
Closed

"path" can be a string or arrray #27

dsantuc opened this issue Aug 10, 2017 · 5 comments

Comments

@dsantuc
Copy link

dsantuc commented Aug 10, 2017

According to the Data Resource spec, the "path" property can be a string or an array of strings:

http://specs.frictionlessdata.io/data-resource/#path-data-in-files

but your code assumes it's an array (e.g. /src/Validators/DatapackageValidator.php:32, /src/Validators/ResourceValidator.php:47).

@OriHoch
Copy link
Collaborator

OriHoch commented Aug 20, 2017

thanks! 👍
the specs kept changing while I was writing this library..

@dsantuc
Copy link
Author

dsantuc commented Aug 29, 2017

I took a stab at it: #28

@OriHoch
Copy link
Collaborator

OriHoch commented Aug 30, 2017

thanks, merged to draft releast v0.1.5

let me know if you want to test it or if I should just publish it

once it's published it will be available via packagist

@dsantuc
Copy link
Author

dsantuc commented Aug 30, 2017

I think it's ok to go.

@OriHoch
Copy link
Collaborator

OriHoch commented Aug 31, 2017

@OriHoch OriHoch closed this as completed Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants