From ed39cc074aa5d25ec8d7fc2e17b69bf97c148cda Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Thu, 16 Aug 2018 10:17:06 -0700 Subject: [PATCH] wasm: Remove --strip-debug argument to LLD Originally added in #52887 this commit disables passing `--strip-debug` to LLD when optimized. This bring back the original bug of emitting broken debuginfo but currently it *also* strips the `name` section which makes it very difficult to inspect the final binary. A real fix is happening at https://reviews.llvm.org/D50729 and we can reevaluate once we've updated LLD to have that commit. --- src/librustc_codegen_llvm/back/linker.rs | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/librustc_codegen_llvm/back/linker.rs b/src/librustc_codegen_llvm/back/linker.rs index ef98fae9cc7ee..6311ab7c74c1c 100644 --- a/src/librustc_codegen_llvm/back/linker.rs +++ b/src/librustc_codegen_llvm/back/linker.rs @@ -1006,18 +1006,6 @@ impl<'a> Linker for WasmLd<'a> { OptLevel::Size => "-O2", OptLevel::SizeMin => "-O2" }); - match self.sess.opts.optimize { - OptLevel::No => (), - OptLevel::Less | - OptLevel::Default | - OptLevel::Aggressive | - OptLevel::Size | - OptLevel::SizeMin => { - // LLD generates incorrect debugging information when - // optimization is applied: strip debug sections. - self.cmd.arg("--strip-debug"); - } - } } fn pgo_gen(&mut self) {